2019-05-20 03:57:03

by Alex Shi

Subject: [PATCH v2 1/3] kselftest/cgroup: fix unexpected testing failure on test_memcontrol

The cgroup testing relies on the root cgroup's subtree_control setting,
If the 'memory' controller isn't set, all test cases will be failed
as following:

$ sudo ./test_memcontrol
not ok 1 test_memcg_subtree_control
not ok 2 test_memcg_current
ok 3 # skip test_memcg_min
not ok 4 test_memcg_low
not ok 5 test_memcg_high
not ok 6 test_memcg_max
not ok 7 test_memcg_oom_events
ok 8 # skip test_memcg_swap_max
not ok 9 test_memcg_sock
not ok 10 test_memcg_oom_group_leaf_events
not ok 11 test_memcg_oom_group_parent_events
not ok 12 test_memcg_oom_group_score_events

To correct this unexpected failure, this patch write the 'memory' to
subtree_control of root to get a right result.

Signed-off-by: Alex Shi <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Roman Gushchin <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Jay Kamat <[email protected]>
Cc: [email protected]
Cc: [email protected]
Reviewed-by: Roman Gushchin <[email protected]>
---
tools/testing/selftests/cgroup/test_memcontrol.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
index 6f339882a6ca..73612d604a2a 100644
--- a/tools/testing/selftests/cgroup/test_memcontrol.c
+++ b/tools/testing/selftests/cgroup/test_memcontrol.c
@@ -1205,6 +1205,10 @@ int main(int argc, char **argv)
if (cg_read_strstr(root, "cgroup.controllers", "memory"))
ksft_exit_skip("memory controller isn't available\n");

+ if (cg_read_strstr(root, "cgroup.subtree_control", "memory"))
+ if (cg_write(root, "cgroup.subtree_control", "+memory"))
+ ksft_exit_skip("Failed to set root memory controller\n");
+
for (i = 0; i < ARRAY_SIZE(tests); i++) {
switch (tests[i].fn(root)) {
case KSFT_PASS:
--
2.19.1.856.g8858448bb

2019-05-24 21:42:04

by Tejun Heo

Subject: Re: [PATCH v2 1/3] kselftest/cgroup: fix unexpected testing failure on test_memcontrol

Hello,

All three patches look good to me. Please feel free to add my
acked-by. Shuah, should I route these through cgroup tree or would
the kselftest tree be a better fit?

Thanks.

--
tejun

2019-05-24 21:46:45

by Shuah Khan

Subject: Re: [PATCH v2 1/3] kselftest/cgroup: fix unexpected testing failure on test_memcontrol

On 5/24/19 3:40 PM, Tejun Heo wrote:
> Hello,
>
> All three patches look good to me. Please feel free to add my
> acked-by. Shuah, should I route these through cgroup tree or would
> the kselftest tree be a better fit?
>
> Thanks.
>


Tejun, I can take them through kselftest tree.

thanks,
-- Shuah

2019-05-25 00:07:57

by Shuah Khan

Subject: Re: [PATCH v2 1/3] kselftest/cgroup: fix unexpected testing failure on test_memcontrol

On 5/24/19 3:44 PM, shuah wrote:
> On 5/24/19 3:40 PM, Tejun Heo wrote:
>> Hello,
>>
>> All three patches look good to me.  Please feel free to add my
>> acked-by.  Shuah, should I route these through cgroup tree or would
>> the kselftest tree be a better fit?
>>
>> Thanks.
>>
>
>
> Tejun, I can take them through kselftest tree.
>

Alex,

patches 1/3 and 2/3 failed checkpatch. Could you please the warns
and send v3. Go ahead and send all v3 for all 3 patches

thanks,
-- Shuah

2019-05-27 06:33:02

by Alex Shi

Subject: Re: [PATCH v2 1/3] kselftest/cgroup: fix unexpected testing failure on test_memcontrol

On 2019/5/25 8:06 上午, shuah wrote:
> Alex,
>
> patches 1/3 and 2/3 failed checkpatch. Could you please the warns
> and send v3. Go ahead and send all v3 for all 3 patches

fixed and rent.

Thanks a lot!
Alex