2004-09-22 19:52:15

by Horst H. von Brand

[permalink] [raw]
Subject: Re: [DOC] Linux kernel patch submission format

Timothy Miller <[email protected]> said:
> Does the Linux kernel source tree include a shell script which will
> compare two trees, create patches, and ask the necessary questions so as
> to format the files correctly with all the right stuff?

diff(1) does what you want...
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513


2004-09-23 07:48:07

by Paul Jackson

[permalink] [raw]
Subject: Re: [DOC] Linux kernel patch submission format

> diff(1) does what you want...

Not all he wanted. There's more to a patch than the diff.

The following three documents explain how to submit patches to the
Linux kernel:

1) Documentation/SubmittingPatches, a file in the kernel source
2) Andrew Morton's "The Perfect Patch", available at:
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
3) Jeff Garzik's "Linux kernel patch submission format", at:
http://linux.yyz.us/patch-format.html

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.650.933.1373

2004-09-24 14:58:47

by Timothy Miller

[permalink] [raw]
Subject: Re: [DOC] Linux kernel patch submission format



Horst von Brand wrote:
> Timothy Miller <[email protected]> said:
>
>>Does the Linux kernel source tree include a shell script which will
>>compare two trees, create patches, and ask the necessary questions so as
>>to format the files correctly with all the right stuff?
>
>
> diff(1) does what you want...

So, in addition to producing the difference, diff also asks you all the
questions necessary for a Linux kernel submission, properly formats
them, and adds them to the diff output?

2004-09-24 15:29:47

by Randy.Dunlap

[permalink] [raw]
Subject: Re: [DOC] Linux kernel patch submission format

On Fri, 24 Sep 2004 11:04:38 -0400 Timothy Miller wrote:

|
|
| Horst von Brand wrote:
| > Timothy Miller <[email protected]> said:
| >
| >>Does the Linux kernel source tree include a shell script which will
| >>compare two trees, create patches, and ask the necessary questions so as
| >>to format the files correctly with all the right stuff?
| >
| >
| > diff(1) does what you want...
|
| So, in addition to producing the difference, diff also asks you all the
| questions necessary for a Linux kernel submission, properly formats
| them, and adds them to the diff output?

Of course not. There is no script in the kernel tree that does
what you asked... but you probably knew that.

Is one really needed? or maybe a GUI IDE is all that is required.


--
~Randy
MOTD: Always include version info.
(Again. Sometimes I think ln -s /usr/src/linux/.config .signature)

2004-10-21 06:26:16

by Timothy Miller

[permalink] [raw]
Subject: Re: [DOC] Linux kernel patch submission format



Randy.Dunlap wrote:
> On Fri, 24 Sep 2004 11:04:38 -0400 Timothy Miller wrote:
>
> |
> |
> | Horst von Brand wrote:
> | > Timothy Miller <[email protected]> said:
> | >
> | >>Does the Linux kernel source tree include a shell script which will
> | >>compare two trees, create patches, and ask the necessary questions so as
> | >>to format the files correctly with all the right stuff?
> | >
> | >
> | > diff(1) does what you want...
> |
> | So, in addition to producing the difference, diff also asks you all the
> | questions necessary for a Linux kernel submission, properly formats
> | them, and adds them to the diff output?
>
> Of course not. There is no script in the kernel tree that does
> what you asked... but you probably knew that.
>
> Is one really needed? or maybe a GUI IDE is all that is required.

Yes, it's needed.

Rather than having a strict policy which many people are going to
violate because they don't understand all the intricacies, it would be
beneficial to have a script that everyone uses which enforces all the rules.

Among other things, this reduces confusion and the barrier to entry.

More patches will be acceptable, and no one will ever have to clean up a
patch which is really important but just not formatted quite right.

Hey, think about it. We're computer geeks who should understand very
well how computers can be used as tools to automate processes, taking
the burden off of humans. Given that dozens of patches are posted every
day, this seems like a prime candidate for automation!

Furthermore, the script can be written to do interesting and helpful
things that no one would consider putting into the policy because they
would be too bothersome for the user to do.

If I knew bash, perl, python, or any other scripting language, I would
volunteer. I don't think you'd like my horribly non-portable C or C++
version, and I don't think Verilog, PHP, or Javascript would quite do
the job either. :)