2005-01-04 11:55:45

by Daniel Drake

[permalink] [raw]
Subject: [PATCH] Wait and retry mounting root device

This is based a patch by William Park <[email protected]> included in
2.6.10-mm1, in order to fix booting from usb-storage devices which no longer
make their partitions immediately available.

While William's patch fixed the situation where you boot from a "root=8:1"
parameter (to correspond to /dev/sda1), it does not allow you to use
"root=/dev/sda1" (which apparently worked in 2.6.9 and earlier), because
the name-->dev_t discovery is done before the "retry" loop starts, and is
not retried during the loop.

This patch, which replaces William's, solves the above problems.

Signed-off-by: Daniel Drake <[email protected]>


Attachments:
boot-delay-retry.patch (1.84 kB)

2005-01-04 22:19:38

by William Park

[permalink] [raw]
Subject: Re: [PATCH] Wait and retry mounting root device

On Tue, Jan 04, 2005 at 12:37:16PM +0000, Daniel Drake wrote:
> This is based a patch by William Park <[email protected]> included in
> 2.6.10-mm1, in order to fix booting from usb-storage devices which no longer
> make their partitions immediately available.
>
> While William's patch fixed the situation where you boot from a "root=8:1"
> parameter (to correspond to /dev/sda1), it does not allow you to use
> "root=/dev/sda1" (which apparently worked in 2.6.9 and earlier), because
> the name-->dev_t discovery is done before the "retry" loop starts, and is
> not retried during the loop.
>
> This patch, which replaces William's, solves the above problems.

It's funny... Your patch does the opposite. It works for
root=/dev/sda1
from the kernel command line, but not from Lilo or 'root=8:1' on command
line. :-)

--
William Park <[email protected]>
Open Geometry Consulting, Toronto, Canada
Linux solution for data processing.

2005-01-05 00:35:56

by Daniel Drake

[permalink] [raw]
Subject: Re: [PATCH] Wait and retry mounting root device

Hi William,

William Park wrote:
> It's funny... Your patch does the opposite. It works for
> root=/dev/sda1
> from the kernel command line, but not from Lilo or 'root=8:1' on command
> line. :-)

Ah, yes :/

I found a simpler way to do it (but I'm not sure if it is 'clean' enough).
I've attached an incremental patch against your first patch. This works with
root=8:1 and root=/dev/sda1 for me.

Andrew, how does this look? I've also attached the new full patch so that you
can also see the context.

Thanks,
Daniel


Attachments:
incremental.patch (650.00 B)
full.patch (1.54 kB)
Download all attachments