2005-10-06 21:34:56

by Alexey Dobriyan

[permalink] [raw]
Subject: [PATCH] msp3400: check ->kthread correctly

Signed-off-by: Alexey Dobriyan <[email protected]>
---

drivers/media/video/msp3400.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- ./drivers/media/video/msp3400.c
+++ ./drivers/media/video/msp3400.c
@@ -1558,7 +1558,7 @@ static int msp_detach(struct i2c_client
struct msp3400c *msp = i2c_get_clientdata(client);

/* shutdown control thread */
- if (msp->kthread >= 0) {
+ if (msp->kthread) {
msp->restart = 1;
kthread_stop(msp->kthread);
}


2005-10-06 23:51:43

by Michael Ira Krufky

[permalink] [raw]
Subject: Re: [PATCH] msp3400: check ->kthread correctly

Alexey Dobriyan wrote:

>Signed-off-by: Alexey Dobriyan <[email protected]>
>---
>
> drivers/media/video/msp3400.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- ./drivers/media/video/msp3400.c
>+++ ./drivers/media/video/msp3400.c
>@@ -1558,7 +1558,7 @@ static int msp_detach(struct i2c_client
> struct msp3400c *msp = i2c_get_clientdata(client);
>
> /* shutdown control thread */
>- if (msp->kthread >= 0) {
>+ if (msp->kthread) {
> msp->restart = 1;
> kthread_stop(msp->kthread);
> }
>
>--
>video4linux-list mailing list
>Unsubscribe mailto:[email protected]?subject=unsubscribe
>https://www.redhat.com/mailman/listinfo/video4linux-list
>
>
Applied to video4linux cvs. Thank you!

CVSROOT: /cvs/video4linux
Module name: video4linux
Changes by: mkrufky 20051007 01:48:36

Modified files:
. : ChangeLog msp3400.c

Log message:
* msp3400.c: (msp_detach):
- check ->kthread correctly

Signed-off-by: Alexey Dobriyan <[email protected]>
Ack'd by: Michael Krufky <[email protected]>

--
Michael Krufky