2005-11-10 22:38:27

by Michael Ira Krufky

[permalink] [raw]
Subject: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings


Attachments:
prevent-saa7134-alsa-undefined-warnings.patch (1.01 kB)

2005-11-11 13:49:12

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings

At Thu, 10 Nov 2005 17:37:58 -0500,
Mike Krufky wrote:
>
> Prevent the following build warnings:
>
> *** Warning: "snd_card_free"
> *** Warning: "snd_card_register"
> *** Warning: "snd_device_new"
> *** Warning: "snd_card_new"
> *** Warning: "snd_ctl_add"
> *** Warning: "snd_ctl_new1"
> *** Warning: "snd_pcm_set_ops"
> *** Warning: "snd_pcm_new"
> *** Warning: "snd_pcm_lib_ioctl"
> *** Warning: "snd_pcm_hw_constraint_integer"
> *** Warning: "snd_pcm_stop"
> *** Warning: "snd_pcm_period_elapsed"
> [drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
>
> Signed-off-by: Michael Krufky <[email protected]>
> Acked-by: Mauro Carvalho Chehab <[email protected]>
>
> drivers/media/video/saa7134/Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/drivers/media/video/saa7134/Kconfig
> +++ linux/drivers/media/video/saa7134/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_SAA7134
> tristate "Philips SAA7134 support"
> - depends on VIDEO_DEV && PCI && I2C && SOUND
> + depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS

No, this driver should select SND_PCM_OSS, instead.


Takashi

2005-11-11 15:26:06

by Michael Ira Krufky

[permalink] [raw]
Subject: Re: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings

Takashi Iwai wrote:
> At Thu, 10 Nov 2005 17:37:58 -0500,
> Mike Krufky wrote:
>
>>Prevent the following build warnings:
>>
>>*** Warning: "snd_card_free"
>>*** Warning: "snd_card_register"
>>*** Warning: "snd_device_new"
>>*** Warning: "snd_card_new"
>>*** Warning: "snd_ctl_add"
>>*** Warning: "snd_ctl_new1"
>>*** Warning: "snd_pcm_set_ops"
>>*** Warning: "snd_pcm_new"
>>*** Warning: "snd_pcm_lib_ioctl"
>>*** Warning: "snd_pcm_hw_constraint_integer"
>>*** Warning: "snd_pcm_stop"
>>*** Warning: "snd_pcm_period_elapsed"
>>[drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
>>
>>Signed-off-by: Michael Krufky <[email protected]>
>>Acked-by: Mauro Carvalho Chehab <[email protected]>
>>
>> drivers/media/video/saa7134/Kconfig | 2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>--- linux.orig/drivers/media/video/saa7134/Kconfig
>>+++ linux/drivers/media/video/saa7134/Kconfig
>>@@ -1,6 +1,6 @@
>> config VIDEO_SAA7134
>> tristate "Philips SAA7134 support"
>>- depends on VIDEO_DEV && PCI && I2C && SOUND
>>+ depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
>
>
> No, this driver should select SND_PCM_OSS, instead.
>
>
> Takashi

Yes, I realized that after Andrew applied the patch. We will send a
correction in our next patchset.

-Michael Krufky