2006-01-08 15:52:18

by Brian Gerst

Subject: [PATCH] modpost: Fix typo

SND_MAX should be FF_MAX

Signed-off-by: Brian Gerst <[email protected]>

---
commit 71bc7fe59ac4b225d6279af4f45affbc5f2eec1b
tree d1789dd69878466807dc3612dc8643c8102bbcda
parent 12a9d2c317f6447caa5c5ccd553780516369f701
author Brian Gerst <[email protected]> Sun, 08 Jan 2006 10:52:26 -0500
committer Brian Gerst <[email protected]> Sun, 08 Jan 2006 10:52:26 -0500

scripts/mod/file2alias.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index e0eedff..be97caf 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -417,7 +417,7 @@ static int do_input_entry(const char *fi
do_input(alias, id->sndbit, 0, SND_MAX);
sprintf(alias + strlen(alias), "f*");
if (id->flags&INPUT_DEVICE_ID_MATCH_FFBIT)
- do_input(alias, id->ffbit, 0, SND_MAX);
+ do_input(alias, id->ffbit, 0, FF_MAX);
sprintf(alias + strlen(alias), "w*");
if (id->flags&INPUT_DEVICE_ID_MATCH_SWBIT)
do_input(alias, id->swbit, 0, SW_MAX);

2006-01-08 17:45:53

by Sam Ravnborg

Subject: Re: [PATCH] modpost: Fix typo

On Sun, Jan 08, 2006 at 10:53:55AM -0500, Brian Gerst wrote:
> SND_MAX should be FF_MAX
>
> Signed-off-by: Brian Gerst <[email protected]>

Applied, though I have not found a way to actually check this one is
correct.

Sam

>
> ---
> commit 71bc7fe59ac4b225d6279af4f45affbc5f2eec1b
> tree d1789dd69878466807dc3612dc8643c8102bbcda
> parent 12a9d2c317f6447caa5c5ccd553780516369f701
> author Brian Gerst <[email protected]> Sun, 08 Jan 2006 10:52:26 -0500
> committer Brian Gerst <[email protected]> Sun, 08 Jan 2006 10:52:26 -0500
>
> scripts/mod/file2alias.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index e0eedff..be97caf 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -417,7 +417,7 @@ static int do_input_entry(const char *fi
> do_input(alias, id->sndbit, 0, SND_MAX);
> sprintf(alias + strlen(alias), "f*");
> if (id->flags&INPUT_DEVICE_ID_MATCH_FFBIT)
> - do_input(alias, id->ffbit, 0, SND_MAX);
> + do_input(alias, id->ffbit, 0, FF_MAX);
> sprintf(alias + strlen(alias), "w*");
> if (id->flags&INPUT_DEVICE_ID_MATCH_SWBIT)
> do_input(alias, id->swbit, 0, SW_MAX);
>
>

2006-01-08 18:22:36

by Brian Gerst

Subject: Re: [PATCH] modpost: Fix typo

Sam Ravnborg wrote:
> On Sun, Jan 08, 2006 at 10:53:55AM -0500, Brian Gerst wrote:
>> SND_MAX should be FF_MAX
>>
>> Signed-off-by: Brian Gerst <[email protected]>
>
> Applied, though I have not found a way to actually check this one is
> correct.
>

id->ffbit is defined as kernel_ulong_t ffbit[FF_MAX/BITS_PER_LONG+1]

--
Brian Gerst