2020-02-05 01:08:14

by Henry Shen

Subject: [PATCH] hwmon: (lm73) Add support for of_match_table

Add the of_match_table.

Henry Shen (1):
hwmon: (lm73) Add support for of_match_table

drivers/hwmon/lm73.c | 10 ++++++++++
1 file changed, 10 insertions(+)

--
2.25.0

2020-02-05 01:09:30

by Henry Shen

Subject: [PATCH] hwmon: (lm73) Add support for of_match_table

Add the of_match_table.
---
drivers/hwmon/lm73.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
index 1eeb9d7de2a0..733c48bf6c98 100644
--- a/drivers/hwmon/lm73.c
+++ b/drivers/hwmon/lm73.c
@@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
return 0;
}

+static const struct of_device_id lm73_of_match[] = {
+ {
+ .compatible = "ti,lm73",
+ },
+ { },
+};
+
+MODULE_DEVICE_TABLE(of, lm73_of_match);
+
static struct i2c_driver lm73_driver = {
.class = I2C_CLASS_HWMON,
.driver = {
.name = "lm73",
+ .of_match_table = lm73_of_match,
},
.probe = lm73_probe,
.id_table = lm73_ids,
--
2.25.0

2020-02-11 02:31:07

by Chris Packham

Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table

On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
> Add the of_match_table.

Needs your Signed-off-by line.

> ---
> drivers/hwmon/lm73.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
> index 1eeb9d7de2a0..733c48bf6c98 100644
> --- a/drivers/hwmon/lm73.c
> +++ b/drivers/hwmon/lm73.c
> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
> return 0;
> }
>
> +static const struct of_device_id lm73_of_match[] = {
> + {
> + .compatible = "ti,lm73",
> + },
> + { },
> +};
> +
> +MODULE_DEVICE_TABLE(of, lm73_of_match);
> +
> static struct i2c_driver lm73_driver = {
> .class = I2C_CLASS_HWMON,
> .driver = {
> .name = "lm73",
> + .of_match_table = lm73_of_match,
> },
> .probe = lm73_probe,
> .id_table = lm73_ids,

2020-02-11 02:33:21

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table

On 2/10/20 6:21 PM, Chris Packham wrote:
> On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
>> Add the of_match_table.
>
> Needs your Signed-off-by line.
>

ti,lm73 would also have to be documented as trivial device.

Guenter

>> ---
>> drivers/hwmon/lm73.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
>> index 1eeb9d7de2a0..733c48bf6c98 100644
>> --- a/drivers/hwmon/lm73.c
>> +++ b/drivers/hwmon/lm73.c
>> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
>> return 0;
>> }
>>
>> +static const struct of_device_id lm73_of_match[] = {
>> + {
>> + .compatible = "ti,lm73",
>> + },
>> + { },
>> +};
>> +
>> +MODULE_DEVICE_TABLE(of, lm73_of_match);
>> +
>> static struct i2c_driver lm73_driver = {
>> .class = I2C_CLASS_HWMON,
>> .driver = {
>> .name = "lm73",
>> + .of_match_table = lm73_of_match,
>> },
>> .probe = lm73_probe,
>> .id_table = lm73_ids,

2020-02-11 02:34:01

by Chris Packham

Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table

On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote:
> On 2/10/20 6:21 PM, Chris Packham wrote:
> > On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
> > > Add the of_match_table.
> >
> > Needs your Signed-off-by line.
> >
>
> ti,lm73 would also have to be documented as trivial device.
>

Yes there's another patch for that. I'll work with Henry to send a v2
series instead of individual patches.

> Guenter
>
> > > ---
> > > drivers/hwmon/lm73.c | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
> > > index 1eeb9d7de2a0..733c48bf6c98 100644
> > > --- a/drivers/hwmon/lm73.c
> > > +++ b/drivers/hwmon/lm73.c
> > > @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
> > > return 0;
> > > }
> > >
> > > +static const struct of_device_id lm73_of_match[] = {
> > > + {
> > > + .compatible = "ti,lm73",
> > > + },
> > > + { },
> > > +};
> > > +
> > > +MODULE_DEVICE_TABLE(of, lm73_of_match);
> > > +
> > > static struct i2c_driver lm73_driver = {
> > > .class = I2C_CLASS_HWMON,
> > > .driver = {
> > > .name = "lm73",
> > > + .of_match_table = lm73_of_match,
> > > },
> > > .probe = lm73_probe,
> > > .id_table = lm73_ids,
>
>

2020-02-11 06:01:41

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table

On 2/10/20 6:32 PM, Chris Packham wrote:
> On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote:
>> On 2/10/20 6:21 PM, Chris Packham wrote:
>>> On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
>>>> Add the of_match_table.
>>>
>>> Needs your Signed-off-by line.
>>>
>>
>> ti,lm73 would also have to be documented as trivial device.
>>
>
> Yes there's another patch for that. I'll work with Henry to send a v2
> series instead of individual patches.
>
DT patches need to be separate patches, or you'll get a complaint from Rob.

On a side note, I don't see the actual patch on hwmon's patchwork,
and I don't recall being copied on it.

Guenter

>> Guenter
>>
>>>> ---
>>>> drivers/hwmon/lm73.c | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
>>>> index 1eeb9d7de2a0..733c48bf6c98 100644
>>>> --- a/drivers/hwmon/lm73.c
>>>> +++ b/drivers/hwmon/lm73.c
>>>> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
>>>> return 0;
>>>> }
>>>>
>>>> +static const struct of_device_id lm73_of_match[] = {
>>>> + {
>>>> + .compatible = "ti,lm73",
>>>> + },
>>>> + { },
>>>> +};
>>>> +
>>>> +MODULE_DEVICE_TABLE(of, lm73_of_match);
>>>> +
>>>> static struct i2c_driver lm73_driver = {
>>>> .class = I2C_CLASS_HWMON,
>>>> .driver = {
>>>> .name = "lm73",
>>>> + .of_match_table = lm73_of_match,
>>>> },
>>>> .probe = lm73_probe,
>>>> .id_table = lm73_ids,
>>
>>