2006-03-16 13:27:30

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] VIDEO_CPIA2 must depend on USB

CONFIG_VIDEO_CPIA2=y, CONFIG_USB=n results in the following compile
error:


<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `set_alternate':cpia2_usb.c:(.text+0x443aa2): undefined reference to `usb_set_interface'
:cpia2_usb.c:(.text+0x443abe): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `cpia2_usb_stream_resume': undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `cpia2_usb_stream_resume': undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `cpia2_usb_stream_pause': undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `cpia2_usb_stream_pause': undefined reference to `usb_free_urb'
drivers/built-in.o: In function `cpia2_usb_disconnect':cpia2_usb.c:(.text+0x443e14): undefined reference to `usb_driver_release_interface'
drivers/built-in.o: In function `cpia2_usb_transfer_cmd': undefined reference to `usb_control_msg'
drivers/built-in.o: In function `cpia2_usb_transfer_cmd': undefined reference to `usb_control_msg'
drivers/built-in.o: In function `cpia2_usb_complete':cpia2_usb.c:(.text+0x444836): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `cpia2_usb_cleanup': undefined reference to `usb_deregister'
drivers/built-in.o: In function `cpia2_usb_init': undefined reference to `usb_register_driver'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-rc6-mm1-full/drivers/media/video/Kconfig.old 2006-03-16 14:19:19.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/drivers/media/video/Kconfig 2006-03-16 14:19:36.000000000 +0100
@@ -144,7 +144,7 @@

config VIDEO_CPIA2
tristate "CPiA2 Video For Linux"
- depends on VIDEO_DEV
+ depends on VIDEO_DEV && USB
---help---
This is the video4linux driver for cameras based on Vision's CPiA2
(Colour Processor Interface ASIC), such as the Digital Blue QX5


2006-03-16 15:47:40

by Michael Ira Krufky

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] VIDEO_CPIA2 must depend on USB

Adrian Bunk wrote:
> CONFIG_VIDEO_CPIA2=y, CONFIG_USB=n results in the following compile
> error:
> <-- snip -->
> Signed-off-by: Adrian Bunk <[email protected]>
>
Adrian-

I've moved the CPIA2 build configuration to cpia2/Kconfig in the v4l-dvb
mercurial tree, so I had to alter your patch slightly in order to apply it.

You can see the regenerated patch at:

http://linuxtv.org/hg/~mkrufky/v4l-dvb?cmd=changeset;node=bdb45ee555aa

Thank you!

Mauro, I have some other build configuration fixes that I haven't
applied to the tree yet, but the following have already been applied and
tested. (using 'make kernel-links') Please pull at your convenience:

http://linuxtv.org/hg/~mkrufky/v4l-dvb

-VIDEO_CPIA2 must depend on USB
-Kconfig: fix VIDEO_PVRUSB2 video decoder build configuration
-Kconfig: remove VIDEO_DECODER
-Kconfig: add menu items for saa7115 decoder and saa7127 encoder modules

Regards,

Michael Krufky