2019-11-07 11:19:58

by Jürgen Groß

Subject: [PATCH v2 0/2] xen/gntdev: sanitize user interface handling

The Xen gntdev driver's checking of the number of allowed mapped pages
is in need of some sanitizing work.

Changes in V2:
- enhanced commit message of patch 1 (Andrew Cooper)

Juergen Gross (2):
xen/gntdev: replace global limit of mapped pages by limit per call
xen/gntdev: switch from kcalloc() to kvcalloc()

drivers/xen/gntdev-common.h | 2 +-
drivers/xen/gntdev-dmabuf.c | 11 +++------
drivers/xen/gntdev.c | 55 +++++++++++++++++++--------------------------
3 files changed, 27 insertions(+), 41 deletions(-)

--
2.16.4

2019-11-28 08:59:35

by Jürgen Groß

Subject: Re: [PATCH v2 0/2] xen/gntdev: sanitize user interface handling

On 07.11.19 12:15, Juergen Gross wrote:
> The Xen gntdev driver's checking of the number of allowed mapped pages
> is in need of some sanitizing work.
>
> Changes in V2:
> - enhanced commit message of patch 1 (Andrew Cooper)
>
> Juergen Gross (2):
> xen/gntdev: replace global limit of mapped pages by limit per call
> xen/gntdev: switch from kcalloc() to kvcalloc()
>
> drivers/xen/gntdev-common.h | 2 +-
> drivers/xen/gntdev-dmabuf.c | 11 +++------
> drivers/xen/gntdev.c | 55 +++++++++++++++++++--------------------------
> 3 files changed, 27 insertions(+), 41 deletions(-)
>

Boris, could you please comment on the patches?


Juergen

2019-11-28 21:45:36

by Boris Ostrovsky

Subject: Re: [PATCH v2 0/2] xen/gntdev: sanitize user interface handling

On 11/28/19 3:48 AM, Jürgen Groß wrote:
> On 07.11.19 12:15, Juergen Gross wrote:
>> The Xen gntdev driver's checking of the number of allowed mapped pages
>> is in need of some sanitizing work.
>>
>> Changes in V2:
>> - enhanced commit message of patch 1 (Andrew Cooper)
>>
>> Juergen Gross (2):
>>    xen/gntdev: replace global limit of mapped pages by limit per call
>>    xen/gntdev: switch from kcalloc() to kvcalloc()
>>
>>   drivers/xen/gntdev-common.h |  2 +-
>>   drivers/xen/gntdev-dmabuf.c | 11 +++------
>>   drivers/xen/gntdev.c        | 55
>> +++++++++++++++++++--------------------------
>>   3 files changed, 27 insertions(+), 41 deletions(-)
>>
>
> Boris, could you please comment on the patches?

Sure, both look good (and so R-b). I haven't commented since Oleksandr
already gave you his.


-boris