2019-10-24 06:29:01

by Krzysztof Kozlowski

Subject: [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree()

Usage of kfree() requires slab.h header. Otherwise building on x86_64
with COMPILE_TEST fails with:

drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/samsung/clk-exynos5433.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index 0b60316331a0..4b1aa9382ad2 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -13,6 +13,7 @@
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
+#include <linux/slab.h>

#include <dt-bindings/clock/exynos5433.h>

--
2.17.1

2019-10-29 18:17:43

by Sylwester Nawrocki

Subject: Re: [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree()

On 10/23/19 18:00, Krzysztof Kozlowski wrote:
> Usage of kfree() requires slab.h header. Otherwise building on x86_64
> with COMPILE_TEST fails with:
>
> drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
> drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration
> of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Thanks, I applied it and squashed with the fix patch from Marek that
introduced the above issue.

--
Regards,
Sylwester