2006-11-23 10:45:26

by Ian molton

[permalink] [raw]
Subject: BUG: 2.6.19-rc6 net/irda/irlmp.c

spin_lock_irqsave_nested is used in net/irda/irlmp.c

Im not sure what it _should_ be, but thought it worth reporting.


2006-11-23 13:13:15

by Jesper Juhl

[permalink] [raw]
Subject: Re: BUG: 2.6.19-rc6 net/irda/irlmp.c

On 23/11/06, Ian Molton <[email protected]> wrote:
> spin_lock_irqsave_nested is used in net/irda/irlmp.c
>
> Im not sure what it _should_ be, but thought it worth reporting.

I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It
is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the
build.

Linus: I think that commit should either be reverted or fixed in a
different way before 2.6.19. As it is right now we have a build
failure :

net/built-in.o: In function `irlmp_slsap_inuse':
net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
make: *** [.tmp_vmlinux1] Error 1

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

2006-11-23 13:20:11

by Peter Zijlstra

[permalink] [raw]
Subject: Re: BUG: 2.6.19-rc6 net/irda/irlmp.c

On Thu, 2006-11-23 at 14:13 +0100, Jesper Juhl wrote:

> Linus: I think that commit should either be reverted or fixed in a
> different way before 2.6.19.

Andrew already said he'd push the required patches to Linus:

http://lkml.org/lkml/2006/11/22/283



2006-11-23 13:25:35

by Jesper Juhl

[permalink] [raw]
Subject: Re: BUG: 2.6.19-rc6 net/irda/irlmp.c

On 23/11/06, Peter Zijlstra <[email protected]> wrote:
> On Thu, 2006-11-23 at 14:13 +0100, Jesper Juhl wrote:
>
> > Linus: I think that commit should either be reverted or fixed in a
> > different way before 2.6.19.
>
> Andrew already said he'd push the required patches to Linus:
>
> http://lkml.org/lkml/2006/11/22/283
>
Ahh, OK, I had missed that. Thank you for pointing that out.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

2006-11-23 19:56:27

by David Miller

[permalink] [raw]
Subject: Re: BUG: 2.6.19-rc6 net/irda/irlmp.c

From: Ian Molton <[email protected]>
Date: Thu, 23 Nov 2006 10:45:40 +0000

> spin_lock_irqsave_nested is used in net/irda/irlmp.c
>
> Im not sure what it _should_ be, but thought it worth reporting.

This has been reported, and explained, about 3 times already.

Andrew Morton will be pushing in a patch to fix this.

2006-11-23 19:57:30

by David Miller

[permalink] [raw]
Subject: Re: BUG: 2.6.19-rc6 net/irda/irlmp.c

From: "Jesper Juhl" <[email protected]>
Date: Thu, 23 Nov 2006 14:13:12 +0100

> I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It
> is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the
> build.
>
> Linus: I think that commit should either be reverted or fixed in a
> different way before 2.6.19. As it is right now we have a build
> failure :
>
> net/built-in.o: In function `irlmp_slsap_inuse':
> net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
> make: *** [.tmp_vmlinux1] Error 1

Andrew will push the change which will fix this bug, please be
patient.