2007-08-06 15:37:06

by Philippe De Muyter

[permalink] [raw]
Subject: uclinux patches submission and author credit

Hi Andrew and Greg,

Currently, all the patches that are submitted via Greg are marked as
authored by Greg. Actually, the author is named in the first
Signed-off-by line (often Greg himself, sometimes someone other).

Would it be possible to fix the patch submission scheme so that the real
author is credited ?

Thanks in advance

Philippe


2007-08-06 16:09:14

by Arjan van de Ven

[permalink] [raw]
Subject: Re: uclinux patches submission and author credit

On Mon, 2007-08-06 at 17:36 +0200, Philippe De Muyter wrote:
> Hi Andrew and Greg,
>
> Currently, all the patches that are submitted via Greg are marked as
> authored by Greg. Actually, the author is named in the first
> Signed-off-by line (often Greg himself, sometimes someone other).
>
> Would it be possible to fix the patch submission scheme so that the real
> author is credited ?

The easiest GIT way to do this is to put a

From: <your name>

in the body of the description; then everything automatically flows from
there..


2007-08-07 06:21:08

by Greg Ungerer

[permalink] [raw]
Subject: Re: uclinux patches submission and author credit

Hi Philippe,

On Mon, 2007-08-06 at 17:36 +0200, Philippe De Muyter wrote:
> Hi Andrew and Greg,
>
> Currently, all the patches that are submitted via Greg are marked as
> authored by Greg. Actually, the author is named in the first
> Signed-off-by line (often Greg himself, sometimes someone other).
>
> Would it be possible to fix the patch submission scheme so that the real
> author is credited ?

Currently if I submit a patch that was sent to me with a
Signed-off-by line I just add mine underneath it and send.
If the patch didn't come with a Signed-off-by then I put the
original author in a "From" line at the top of the submission.
Looks like I should always add a "From" line.

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: [email protected]
Secure Computing Corporation PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com

2007-08-07 15:04:54

by Philippe De Muyter

[permalink] [raw]
Subject: Re: uclinux patches submission and author credit

Hi Greg,

On Tue, Aug 07, 2007 at 04:20:54PM +1000, Greg Ungerer wrote:

> Currently if I submit a patch that was sent to me with a
> Signed-off-by line I just add mine underneath it and send.
> If the patch didn't come with a Signed-off-by then I put the
> original author in a "From" line at the top of the submission.
> Looks like I should always add a "From" line.

That's fine. Thanks. I didn't know either about the From: field.

Philippe