Hello,
(please, don't blame me for using the binary only driver, I will
happily switch to a open source one once it properly runs mplayer,
e.g.).
Renaming the config options for suspend/sleep broke fglrx power
management.
--- firegl_public.h.orig 2007-10-11 23:43:26.000000000 +0200
+++ firegl_public.h 2007-10-11 23:53:08.000000000 +0200
@@ -172,7 +172,7 @@
#endif
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-#if !defined(CONFIG_SMP) || defined(CONFIG_SUSPEND_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13)
+#if !defined(CONFIG_SMP) || defined(CONFIG_PM_SLEEP_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13)
#define FIREGL_POWER_MANAGEMENT
#endif
#endif
--
MfG,
Michael Leun
Hi,
On Friday, 12 October 2007 00:07, Michael Leun wrote:
> Hello,
>
> (please, don't blame me for using the binary only driver, I will
> happily switch to a open source one once it properly runs mplayer,
> e.g.).
>
> Renaming the config options for suspend/sleep broke fglrx power
> management.
It looks like your patch is against the fglrx driver, isn't it?
> --- firegl_public.h.orig 2007-10-11 23:43:26.000000000 +0200
> +++ firegl_public.h 2007-10-11 23:53:08.000000000 +0200
> @@ -172,7 +172,7 @@
> #endif
>
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
> -#if !defined(CONFIG_SMP) || defined(CONFIG_SUSPEND_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13)
> +#if !defined(CONFIG_SMP) || defined(CONFIG_PM_SLEEP_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13)
> #define FIREGL_POWER_MANAGEMENT
> #endif
> #endif
>
>
Greetings,
Rafael
On Fri, 12 Oct 2007 01:31:17 +0200
"Rafael J. Wysocki" <[email protected]> wrote:
> Hi,
>
> On Friday, 12 October 2007 00:07, Michael Leun wrote:
> > Hello,
> >
> > (please, don't blame me for using the binary only driver, I will
> > happily switch to a open source one once it properly runs mplayer,
> > e.g.).
> >
> > Renaming the config options for suspend/sleep broke fglrx power
> > management.
>
> It looks like your patch is against the fglrx driver, isn't it?
It is - I should have mentioned that, sorry.
--
MfG,
Michael Leun
On Fri, Oct 12, 2007 at 01:49:07AM +0200, Michael Leun wrote:
> On Fri, 12 Oct 2007 01:31:17 +0200
> "Rafael J. Wysocki" <[email protected]> wrote:
>
> > Hi,
> >
> > On Friday, 12 October 2007 00:07, Michael Leun wrote:
> > > Hello,
> > >
> > > (please, don't blame me for using the binary only driver, I will
> > > happily switch to a open source one once it properly runs mplayer,
> > > e.g.).
> > >
> > > Renaming the config options for suspend/sleep broke fglrx power
> > > management.
> >
> > It looks like your patch is against the fglrx driver, isn't it?
>
> It is - I should have mentioned that, sorry.
This makes it 100% off-topic for linux-kernel - please send patches for
illegal modules to the vendors of these modules and not here.
> MfG,
>
> Michael Leun
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Friday, 12 October 2007 02:06, Adrian Bunk wrote:
> On Fri, Oct 12, 2007 at 01:49:07AM +0200, Michael Leun wrote:
> > On Fri, 12 Oct 2007 01:31:17 +0200
> > "Rafael J. Wysocki" <[email protected]> wrote:
> >
> > > Hi,
> > >
> > > On Friday, 12 October 2007 00:07, Michael Leun wrote:
> > > > Hello,
> > > >
> > > > (please, don't blame me for using the binary only driver, I will
> > > > happily switch to a open source one once it properly runs mplayer,
> > > > e.g.).
> > > >
> > > > Renaming the config options for suspend/sleep broke fglrx power
> > > > management.
> > >
> > > It looks like your patch is against the fglrx driver, isn't it?
> >
> > It is - I should have mentioned that, sorry.
>
> This makes it 100% off-topic for linux-kernel - please send patches for
> illegal modules to the vendors of these modules and not here.
Well, the information that it got broken by itself is valuable, so thanks for
it Michael, but the patch is certainly not interesting to us. :-)
Greetings,
Rafael
Adrian Bunk wrote:
> On Fri, Oct 12, 2007 at 01:49:07AM +0200, Michael Leun wrote:
>> On Fri, 12 Oct 2007 01:31:17 +0200
>> "Rafael J. Wysocki" <[email protected]> wrote:
>>
>>> Hi,
>>>
>>> On Friday, 12 October 2007 00:07, Michael Leun wrote:
>>>> Hello,
>>>>
>>>> (please, don't blame me for using the binary only driver, I will
>>>> happily switch to a open source one once it properly runs mplayer,
>>>> e.g.).
>>>>
>>>> Renaming the config options for suspend/sleep broke fglrx power
>>>> management.
>>> It looks like your patch is against the fglrx driver, isn't it?
>> It is - I should have mentioned that, sorry.
>
> This makes it 100% off-topic for linux-kernel - please send patches for
> illegal modules to the vendors of these modules and not here.
>
Which would help the actual users of the module not one whit. Whereas
putting the patch here helps the people who need it and allows multiple
people to complain to the vendor.
If this module violates some law you should report it to the appropriate
authorities rather than posting it here, otherwise you should probably
should not use the term illegal casually.
--
Bill Davidsen <[email protected]>
"We have more to fear from the bungling of the incompetent than from
the machinations of the wicked." - from Slashdot
On Fri, Oct 12, 2007 at 08:33:14AM -0400, Bill Davidsen wrote:
> Adrian Bunk wrote:
>> On Fri, Oct 12, 2007 at 01:49:07AM +0200, Michael Leun wrote:
>>> On Fri, 12 Oct 2007 01:31:17 +0200
>>> "Rafael J. Wysocki" <[email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Friday, 12 October 2007 00:07, Michael Leun wrote:
>>>>> Hello,
>>>>>
>>>>> (please, don't blame me for using the binary only driver, I will
>>>>> happily switch to a open source one once it properly runs mplayer,
>>>>> e.g.).
>>>>>
>>>>> Renaming the config options for suspend/sleep broke fglrx power
>>>>> management.
>>>> It looks like your patch is against the fglrx driver, isn't it?
>>> It is - I should have mentioned that, sorry.
>> This makes it 100% off-topic for linux-kernel - please send patches for
>> illegal modules to the vendors of these modules and not here.
> Which would help the actual users of the module not one whit. Whereas
> putting the patch here helps the people who need it and allows multiple
> people to complain to the vendor.
>...
The vendor has his own forums and support channels.
That's what the term "off-topic" describes.
And what's worst is that people on this list might become tainted
by seeing part of the fglrx source code.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed