2022-08-12 12:14:58

by Saba Kareem, Syed

[permalink] [raw]
Subject: [PATCH 10/13] ASoC: amd: enable Pink Sardine acp6.2 drivers build

Pink Sardine ACP6.2 drivers can be built by selecting necessary
kernel config option.
The patch enables build support of the same.

Signed-off-by: Syed Saba Kareem <[email protected]>wq
---
sound/soc/amd/Kconfig | 10 ++++++++++
sound/soc/amd/Makefile | 1 +
sound/soc/amd/ps/Makefile | 7 +++++++
3 files changed, 18 insertions(+)
create mode 100644 sound/soc/amd/ps/Makefile

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 08f5289dac54..0f461beca274 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -127,3 +127,13 @@ config SND_SOC_AMD_RPL_ACP6x
triggered for ACP PCI driver.
Say m if you have such a device.
If unsure select "N".
+
+config SND_SOC_AMD_PS
+ tristate "AMD Audio Coprocessor-v6.2 Pink Sardine support"
+ depends on X86 && PCI
+ help
+ This option enables Audio Coprocessor i.e ACP v6.2 support on
+ AMD Pink sardine platform. By enabling this flag build will be
+ triggered for ACP PCI driver, ACP PDM DMA driver.
+ Say m if you have such a device.
+ If unsure select "N".
diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
index 0592e7c5c407..82e1cf864a40 100644
--- a/sound/soc/amd/Makefile
+++ b/sound/soc/amd/Makefile
@@ -18,3 +18,4 @@ obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
obj-$(CONFIG_SND_SOC_AMD_ACP_COMMON) += acp/
obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
+obj-$(CONFIG_SND_SOC_AMD_PS) += ps/
diff --git a/sound/soc/amd/ps/Makefile b/sound/soc/amd/ps/Makefile
new file mode 100644
index 000000000000..23afa5e32ffa
--- /dev/null
+++ b/sound/soc/amd/ps/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0+
+# Pink Sardine platform Support
+snd-pci-ps-objs := pci-ps.o
+snd-ps-pdm-dma-objs := ps-pdm-dma.o
+
+obj-$(CONFIG_SND_SOC_AMD_PS) += snd-pci-ps.o
+obj-$(CONFIG_SND_SOC_AMD_PS) += snd-ps-pdm-dma.o
--
2.25.1


2022-08-12 14:21:27

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 10/13] ASoC: amd: enable Pink Sardine acp6.2 drivers build

On Fri, Aug 12, 2022 at 05:37:28PM +0530, Syed Saba kareem wrote:

> +config SND_SOC_AMD_PS
> + tristate "AMD Audio Coprocessor-v6.2 Pink Sardine support"
> + depends on X86 && PCI

Could this be

depends on X86 || COMPILE_TEST
depends on PCI

to improve build coverage?


Attachments:
(No filename) (299.00 B)
signature.asc (499.00 B)
Download all attachments

2022-08-16 09:14:22

by syed saba kareem

[permalink] [raw]
Subject: Re: [PATCH 10/13] ASoC: amd: enable Pink Sardine acp6.2 drivers build

Will fix it and Will resend the patch series.

On 8/12/22 19:35, Mark Brown wrote:
> [CAUTION: External Email]

2022-08-27 17:00:57

by syed saba kareem

[permalink] [raw]
Subject: Re: [PATCH 10/13] ASoC: amd: enable Pink Sardine acp6.2 drivers build


On 8/12/22 19:35, Mark Brown wrote:
> [CAUTION: External Email]

ACP Driver has strict dependency on ACPI
COMPILE_TEST will relax the flag options. As ACP PCI driver has strict
dependency,compile test flag cannot be used in this case.