2008-01-28 22:12:32

by Adrian Bunk

Subject: [2.6 patch] dvb/frontends/xc5000.c: make a struct static

struct XC5000_Standard[] can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
e1f9c8304c807ecce026156ee2185925295fe835
diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c
index f642ca2..a5094b7 100644
--- a/drivers/media/dvb/frontends/xc5000.c
+++ b/drivers/media/dvb/frontends/xc5000.c
@@ -151,7 +151,7 @@ typedef struct {
#define FM_Radio_INPUT2 21
#define FM_Radio_INPUT1 22

-XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
+static XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
{"M/N-NTSC/PAL-BTSC", 0x0400, 0x8020},
{"M/N-NTSC/PAL-A2", 0x0600, 0x8020},
{"M/N-NTSC/PAL-EIAJ", 0x0440, 0x8020},

2008-01-28 23:12:49

by Steven Toth

Subject: Re: [v4l-dvb-maintainer] [2.6 patch] dvb/frontends/xc5000.c: make a struct static

Adrian Bunk wrote:
> struct XC5000_Standard[] can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Reviewed-by: Steven Toth <[email protected]>

Thanks Adrian.

Mauro, please merge.

- Steve

>
> ---
> e1f9c8304c807ecce026156ee2185925295fe835
> diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c
> index f642ca2..a5094b7 100644
> --- a/drivers/media/dvb/frontends/xc5000.c
> +++ b/drivers/media/dvb/frontends/xc5000.c
> @@ -151,7 +151,7 @@ typedef struct {
> #define FM_Radio_INPUT2 21
> #define FM_Radio_INPUT1 22
>
> -XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
> +static XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
> {"M/N-NTSC/PAL-BTSC", 0x0400, 0x8020},
> {"M/N-NTSC/PAL-A2", 0x0600, 0x8020},
> {"M/N-NTSC/PAL-EIAJ", 0x0440, 0x8020},
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> [email protected]
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer