2021-02-24 00:02:39

by William Durand

Subject: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

Fixes a checkpatch CHECK issue.

Signed-off-by: William Durand <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 11269fe6b395..1bbb9ed18e6d 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -179,7 +179,6 @@ struct rt_hi_throughput {
} __packed;

struct bss_ht {
-
u8 bdSupportHT;

u8 bdHTCapBuf[32];
--
2.30.0

2021-02-24 12:58:58

by Dan Carpenter

Subject: Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

On Sat, Feb 20, 2021 at 03:54:05PM +0000, William Durand wrote:
> Fixes a checkpatch CHECK issue.
>

All these patches have the same vague commit message. It's okay if the
commit message basically restates the commit one line summary. It
should say something like:

Fix a checkpatch warning about a blank line after an open curly brace.

Rename FooBar to foo_bar to silence a checkpatch warning about
CamelCase.

regards,
dan carpenter

2021-02-24 20:06:59

by William Durand

Subject: Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

> All these patches have the same vague commit message. It's okay if the
> commit message basically restates the commit one line summary. It
> should say something like:
>
> Fix a checkpatch warning about a blank line after an open curly brace.
>
> Rename FooBar to foo_bar to silence a checkpatch warning about
> CamelCase.

Thanks, I'll update the patchset!