2018-04-19 06:53:17

by Baolin Wang

Subject: [PATCH] parisc: time: Convert read_persistent_clock() to read_persistent_clock64()

The read_persistent_clock() uses a timespec, which is not year 2038 safe
on 32bit systems. On parisc architecture, we have implemented generic RTC
drivers that can be used to compensate the system suspend time, but the
RTC time can not represent the nanosecond resolution, so this patch just
converts to read_persistent_clock64() with timespec64.

Signed-off-by: Baolin Wang <[email protected]>
---
arch/parisc/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index c383040..a1e772f 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -205,7 +205,7 @@ static int __init rtc_init(void)
device_initcall(rtc_init);
#endif

-void read_persistent_clock(struct timespec *ts)
+void read_persistent_clock64(struct timespec64 *ts)
{
static struct pdc_tod tod_data;
if (pdc_tod_read(&tod_data) == 0) {
--
1.7.9.5

2018-04-20 15:25:24

by Arnd Bergmann

Subject: Re: [PATCH] parisc: time: Convert read_persistent_clock() to read_persistent_clock64()

On Thu, Apr 19, 2018 at 8:51 AM, Baolin Wang <[email protected]> wrote:
> The read_persistent_clock() uses a timespec, which is not year 2038 safe
> on 32bit systems. On parisc architecture, we have implemented generic RTC
> drivers that can be used to compensate the system suspend time, but the
> RTC time can not represent the nanosecond resolution, so this patch just
> converts to read_persistent_clock64() with timespec64.
>
> Signed-off-by: Baolin Wang <[email protected]>

I have created the exact same patch a while ago but never submitted that.

If the parisc maintainers want to apply yours with my Ack, that
would be appreciated.

Acked-by: Arnd Bergmann <[email protected]>

2018-04-20 18:16:12

by Helge Deller

Subject: Re: [PATCH] parisc: time: Convert read_persistent_clock() to read_persistent_clock64()

On 20.04.2018 17:23, Arnd Bergmann wrote:
> On Thu, Apr 19, 2018 at 8:51 AM, Baolin Wang <[email protected]> wrote:
>> The read_persistent_clock() uses a timespec, which is not year 2038 safe
>> on 32bit systems. On parisc architecture, we have implemented generic RTC
>> drivers that can be used to compensate the system suspend time, but the
>> RTC time can not represent the nanosecond resolution, so this patch just
>> converts to read_persistent_clock64() with timespec64.
>>
>> Signed-off-by: Baolin Wang <[email protected]>
>
> I have created the exact same patch a while ago but never submitted that.
>
> If the parisc maintainers want to apply yours with my Ack, that
> would be appreciated.
>
> Acked-by: Arnd Bergmann <[email protected]>

Thanks, I'll take it through the parisc git tree.

Helge