2022-05-13 09:28:02

by Zhang Jianhua

Subject: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables

The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
been initialized but not used, they are redundant and remove them.

Signed-off-by: Zhang Jianhua <[email protected]>

---
No code changes since v1, only remove the redundant line "--------" in
v1 commit message.
---
drivers/tty/vt/defkeymap.c_shipped | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
index 094d95bf0005..80dee50bcb7a 100644
--- a/drivers/tty/vt/defkeymap.c_shipped
+++ b/drivers/tty/vt/defkeymap.c_shipped
@@ -185,10 +185,6 @@ char func_buf[] = {
'\033', '[', 'P', 0,
};

-char *funcbufptr = func_buf;
-int funcbufsize = sizeof(func_buf);
-int funcbufleft = 0; /* space left */
-
char *func_table[MAX_NR_FUNC] = {
func_buf + 0,
func_buf + 5,
--
2.31.0

2022-05-16 20:23:38

by Jiri Slaby

Subject: Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables

On 13. 05. 22, 3:54, Zhang Jianhua wrote:
> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> been initialized but not used, they are redundant and remove them.
>
> Signed-off-by: Zhang Jianhua <[email protected]>
>
> ---
> No code changes since v1, only remove the redundant line "--------" in
> v1 commit message.
> ---
> drivers/tty/vt/defkeymap.c_shipped | 4 ----

The file header says:
/* Do not edit this file! It was automatically generated by */
/* loadkeys --mktable defkeymap.map > defkeymap.c */

So I'm not sure anyone wants to touch it.

> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -185,10 +185,6 @@ char func_buf[] = {
> '\033', '[', 'P', 0,
> };
>
> -char *funcbufptr = func_buf;
> -int funcbufsize = sizeof(func_buf);
> -int funcbufleft = 0; /* space left */
> -
> char *func_table[MAX_NR_FUNC] = {
> func_buf + 0,
> func_buf + 5,


--
js
suse labs

2022-05-17 03:00:44

by Zhang Jianhua

Subject: Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables

在 2022/5/16 15:00, Jiri Slaby 写道:
> On 13. 05. 22, 3:54, Zhang Jianhua wrote:
>> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
>> been initialized but not used, they are redundant and remove them.
>>
>> Signed-off-by: Zhang Jianhua <[email protected]>
>>
>> ---
>> No code changes since v1, only remove the redundant line "--------" in
>> v1 commit message.
>> ---
>>   drivers/tty/vt/defkeymap.c_shipped | 4 ----
>
> The file header says:
> /* Do not edit this file! It was automatically generated by   */
> /*    loadkeys --mktable defkeymap.map > defkeymap.c */
>
> So I'm not sure anyone wants to touch it.
This notes will be copied to the file defkeymap.c completely which is
automatically generated, so it says to defkeymap.c rather than defkeymap.map
>
>> --- a/drivers/tty/vt/defkeymap.c_shipped
>> +++ b/drivers/tty/vt/defkeymap.c_shipped
>> @@ -185,10 +185,6 @@ char func_buf[] = {
>>       '\033', '[', 'P', 0,
>>   };
>>   -char *funcbufptr = func_buf;
>> -int funcbufsize = sizeof(func_buf);
>> -int funcbufleft = 0;          /* space left */
>> -
>>   char *func_table[MAX_NR_FUNC] = {
>>       func_buf + 0,
>>       func_buf + 5,
>
>