2009-06-10 01:47:40

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH 2/3] mtd/maps: uclinux: mark local stuff static


Mike Frysinger wrote:
> The uclinux_ram_mtdinfo, uclinux_romfs, and uclinux_point symbols do not
> need to be visible outside of this module, so mark them static.
>
> Signed-off-by: Mike Frysinger <[email protected]>
> CC: Greg Ungerer <[email protected]>

Acked-by: Greg Ungerer <[email protected]>


> CC: [email protected]
> CC: [email protected]
> ---
> drivers/mtd/maps/uclinux.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
> index 61d4087..d4314fb 100644
> --- a/drivers/mtd/maps/uclinux.c
> +++ b/drivers/mtd/maps/uclinux.c
> @@ -30,11 +30,11 @@ struct map_info uclinux_ram_map = {
> .size = 0,
> };
>
> -struct mtd_info *uclinux_ram_mtdinfo;
> +static struct mtd_info *uclinux_ram_mtdinfo;
>
> /****************************************************************************/
>
> -struct mtd_partition uclinux_romfs[] = {
> +static struct mtd_partition uclinux_romfs[] = {
> { .name = "ROMfs" }
> };
>
> @@ -42,7 +42,7 @@ struct mtd_partition uclinux_romfs[] = {
>
> /****************************************************************************/
>
> -int uclinux_point(struct mtd_info *mtd, loff_t from, size_t len,
> +static int uclinux_point(struct mtd_info *mtd, loff_t from, size_t len,
> size_t *retlen, void **virt, resource_size_t *phys)
> {
> struct map_info *map = mtd->priv;

--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com