2009-10-12 21:32:20

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c

tip-bot for H. Peter Anvin wrote:
> Commit-ID: 98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Gitweb: http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Author: H. Peter Anvin<[email protected]>
> AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700
> Committer: H. Peter Anvin<[email protected]>
> CommitDate: Mon, 12 Oct 2009 14:19:35 -0700
>
> x86: use kernel_stack_pointer() in kprobes.c
>
> The way to obtain a kernel-mode stack pointer from a struct pt_regs in
> 32-bit mode is "subtle": the stack doesn't actually contain the stack
> pointer, but rather the location where it would have been marks the
> actual previous stack frame. For clarity, use kernel_stack_pointer()
> instead of coding this weirdness explicitly.
>
> Signed-off-by: H. Peter Anvin<[email protected]>
> Cc: Ananth N Mavinakayanahalli<[email protected]>
> Cc: Anil S Keshavamurthy<[email protected]>
> Cc: "David S. Miller"<[email protected]>
> Cc: Masami Hiramatsu<[email protected]>

Acked-by: Masami Hiramatsu <[email protected]>

Thank you for fixing it!


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: [email protected]