2010-01-14 03:03:48

by Li Zefan

Subject: [PATCH] perf probe: Fix build failure

builtin-probe.c:121: error: 'opt_show_lines' defined but not used

Signed-off-by: Li Zefan <[email protected]>
---
tools/perf/builtin-probe.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 1d3a99e..9be8063 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -118,6 +118,7 @@ static int opt_del_probe_event(const struct option *opt __used,
return 0;
}

+#ifndef NO_LIBDWARF
static int opt_show_lines(const struct option *opt __used,
const char *str, int unset __used)
{
@@ -127,6 +128,8 @@ static int opt_show_lines(const struct option *opt __used,
session.show_lines = true;
return 0;
}
+#endif
+
/* Currently just checking function name from symbol map */
static void evaluate_probe_point(struct probe_point *pp)
{
--
1.6.3

2010-01-14 04:48:44

by Masami Hiramatsu

Subject: Re: [PATCH] perf probe: Fix build failure

Hi,

Thank you, the patch code looks good to me.

Li Zefan wrote:
> builtin-probe.c:121: error: 'opt_show_lines' defined but not used

Please add some comment for explanation, like:

This build error occurs when compiling perf-tools without dwarf
support (no libdwarf).

>
> Signed-off-by: Li Zefan <[email protected]>
> ---
> tools/perf/builtin-probe.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index 1d3a99e..9be8063 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -118,6 +118,7 @@ static int opt_del_probe_event(const struct option *opt __used,
> return 0;
> }
>
> +#ifndef NO_LIBDWARF
> static int opt_show_lines(const struct option *opt __used,
> const char *str, int unset __used)
> {
> @@ -127,6 +128,8 @@ static int opt_show_lines(const struct option *opt __used,
> session.show_lines = true;
> return 0;
> }
> +#endif
> +
> /* Currently just checking function name from symbol map */
> static void evaluate_probe_point(struct probe_point *pp)
> {

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: [email protected]

2010-01-14 05:23:35

by Li Zefan

Subject: Re: [PATCH] perf probe: Fix build failure

Masami Hiramatsu wrote:
> Hi,
>
> Thank you, the patch code looks good to me.
>
> Li Zefan wrote:
>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
>
> Please add some comment for explanation, like:
>
> This build error occurs when compiling perf-tools without dwarf
> support (no libdwarf).
>

But as simple as this patch, the code itself has explained
the cause of this compile error.

2010-01-14 06:18:36

by Masami Hiramatsu

Subject: Re: [PATCH] perf probe: Fix build failure

Li Zefan wrote:
> Masami Hiramatsu wrote:
>> Hi,
>>
>> Thank you, the patch code looks good to me.
>>
>> Li Zefan wrote:
>>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
>>
>> Please add some comment for explanation, like:
>>
>> This build error occurs when compiling perf-tools without dwarf
>> support (no libdwarf).
>>
>
> But as simple as this patch, the code itself has explained
> the cause of this compile error.

If someone looks git-log afterwords, below message seems too
short.
---
perf probe: Fix build failure

builtin-probe.c:121: error: 'opt_show_lines' defined but not used
---
Especially, if there is libdwarf, we will not see above error. So
IMHO, at least we'd better add a comment about how the error occurs.

Thank you,

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: [email protected]

2010-01-14 06:30:56

by Li Zefan

Subject: Re: [PATCH] perf probe: Fix build failure

>>>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
>>> Please add some comment for explanation, like:
>>>
>>> This build error occurs when compiling perf-tools without dwarf
>>> support (no libdwarf).
>>>
>> But as simple as this patch, the code itself has explained
>> the cause of this compile error.
>
> If someone looks git-log afterwords, below message seems too
> short.
> ---
> perf probe: Fix build failure
>
> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
> ---
> Especially, if there is libdwarf, we will not see above error. So
> IMHO, at least we'd better add a comment about how the error occurs.
>

Fair enough, here's the updated patch, and I guess I can
add you acked-by.

=============

From: Li Zefan <[email protected]>
Subject: [PATCH] perf probe: Fix build failure

When compiling perf-tools without dwarf support, I ran into this:

builtin-probe.c:121: error: 'opt_show_lines' defined but not used

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Masami Hiramatsu <[email protected]>
---
tools/perf/builtin-probe.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 1d3a99e..9be8063 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -118,6 +118,7 @@ static int opt_del_probe_event(const struct option *opt __used,
return 0;
}

+#ifndef NO_LIBDWARF
static int opt_show_lines(const struct option *opt __used,
const char *str, int unset __used)
{
@@ -127,6 +128,8 @@ static int opt_show_lines(const struct option *opt __used,
session.show_lines = true;
return 0;
}
+#endif
+
/* Currently just checking function name from symbol map */
static void evaluate_probe_point(struct probe_point *pp)
{
--
1.6.3