2012-02-01 09:40:14

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 3/5] TTY: use tty_standard_install

On 01/30/2012 09:14 PM, Jiri Slaby wrote:
> Use the helper in the rest of the tty drivers. This is a simple
> replacement.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Alan Cox <[email protected]>
> ---
> drivers/isdn/capi/capi.c | 9 +++------
> drivers/misc/pti.c | 6 +-----
> drivers/mmc/card/sdio_uart.c | 9 +++------
> drivers/tty/nozomi.c | 8 ++------
> 4 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
> index e44933d..ca9261a 100644
> --- a/drivers/isdn/capi/capi.c
> +++ b/drivers/isdn/capi/capi.c
> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
> {
> int idx = tty->index;
> struct capiminor *mp = capiminor_get(idx);
> - int ret = tty_init_termios(tty);
> + int ret = tty_standard_install(tty);

Uh, what version of the patch did I send? tty_standard_install takes 2
arguments! I will post the correct one in a moment.

sorry,
--
js


2012-02-01 09:52:40

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 3/5] TTY: use tty_standard_install

On 02/01/2012 10:40 AM, Jiri Slaby wrote:
> On 01/30/2012 09:14 PM, Jiri Slaby wrote:
>> Use the helper in the rest of the tty drivers. This is a simple
>> replacement.
>>
>> Signed-off-by: Jiri Slaby <[email protected]>
>> Cc: Greg Kroah-Hartman <[email protected]>
>> Cc: Alan Cox <[email protected]>
>> ---
>> drivers/isdn/capi/capi.c | 9 +++------
>> drivers/misc/pti.c | 6 +-----
>> drivers/mmc/card/sdio_uart.c | 9 +++------
>> drivers/tty/nozomi.c | 8 ++------
>> 4 files changed, 9 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
>> index e44933d..ca9261a 100644
>> --- a/drivers/isdn/capi/capi.c
>> +++ b/drivers/isdn/capi/capi.c
>> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
>> {
>> int idx = tty->index;
>> struct capiminor *mp = capiminor_get(idx);
>> - int ret = tty_init_termios(tty);
>> + int ret = tty_standard_install(tty);
>
> Uh, what version of the patch did I send? tty_standard_install takes 2
> arguments! I will post the correct one in a moment.

If my ISP's smtp server actually worked now. The patch is attached,
hopefully my mailer won't screw it.

thanks,
--
js


Attachments:
0003-TTY-use-tty_standard_install.patch (3.07 kB)