LinuxLists.cc - linux-next: build warning after merge of the libata tree

2012-02-13 05:27:48

Subject: linux-next: build warning after merge of the libata tree

Hi Jeff,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]

Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
to the ACPI device tree") and c9df614ade0e ("libata: Add links between
removable devices and docks").
--
Cheers,
Stephen Rothwell [email protected]

Attachments:

(No filename) (1.54 kB)
(No filename) (836.00 B)
Download all attachments

2012-02-24 03:08:29

by Stephen Rothwell

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the libata tree

Hi Jeff, Matthew,

On Mon, 13 Feb 2012 16:27:40 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>
> Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
> to the ACPI device tree") and c9df614ade0e ("libata: Add links between
> removable devices and docks").

Ping?
--
Cheers,
Stephen Rothwell [email protected]

Attachments:

(No filename) (1.67 kB)
(No filename) (836.00 B)
Download all attachments

2012-02-24 04:06:16

by Jeff Garzik

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the libata tree

On 02/23/2012 10:08 PM, Stephen Rothwell wrote:
> Hi Jeff, Matthew,
>
> On Mon, 13 Feb 2012 16:27:40 +1100 Stephen Rothwell<[email protected]> wrote:
>>
>> After merging the libata tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>>
>> Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
>> to the ACPI device tree") and c9df614ade0e ("libata: Add links between
>> removable devices and docks").
>
> Ping?

A build fix and oops fix were both just pushed out.

Jeff

2012-02-24 04:14:22

by Stephen Rothwell

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the libata tree

Hi Jeff,

On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik <[email protected]> wrote:
>
> A build fix and oops fix were both just pushed out.

Excellent, thanks.

--
Cheers,
Stephen Rothwell [email protected]

Attachments:

(No filename) (228.00 B)
(No filename) (836.00 B)
Download all attachments

2012-02-24 12:22:38

by Stephen Rothwell

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the libata tree

Hi Jeff,

On Fri, 24 Feb 2012 15:14:10 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik <[email protected]> wrote:
> >
> > A build fix and oops fix were both just pushed out.
>
> Excellent, thanks.

Except the commits in the current version of the libata tree destined for
linux-next do not fix the warnings I was reporting where the "inline"
keyword is missing from several static function definitions in
drivers/ata/libata.h ...

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:

(No filename) (589.00 B)
(No filename) (836.00 B)
Download all attachments

2012-02-24 17:02:03

by Jeff Garzik

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the libata tree

On 02/24/2012 07:22 AM, Stephen Rothwell wrote:
> Hi Jeff,
>
> On Fri, 24 Feb 2012 15:14:10 +1100 Stephen Rothwell<[email protected]> wrote:
>>
>> On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik<[email protected]> wrote:
>>>
>>> A build fix and oops fix were both just pushed out.
>>
>> Excellent, thanks.
>
> Except the commits in the current version of the libata tree destined for
> linux-next do not fix the warnings I was reporting where the "inline"
> keyword is missing from several static function definitions in
> drivers/ata/libata.h ...

Patchset backed out, and hopefully this will get fixed before it appears
again in linux-next.

Jeff