2012-06-11 23:47:11

by Randy Dunlap

Subject: [PATCH] exofs: fix sparse non-ANSI function warning

From: Randy Dunlap <[email protected]>

Fix sparse non-ANSI function warning:

fs/exofs/sys.c:112:28: warning: non-ANSI function declaration of function 'exofs_sysfs_dbg_print'

Signed-off-by: Randy Dunlap <[email protected]>
---
fs/exofs/sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-35-rc2.orig/fs/exofs/sys.c
+++ lnx-35-rc2/fs/exofs/sys.c
@@ -109,7 +109,7 @@ static struct kobj_type odev_ktype = {
static struct kobj_type uuid_ktype = {
};

-void exofs_sysfs_dbg_print()
+void exofs_sysfs_dbg_print(void)
{
#ifdef CONFIG_EXOFS_DEBUG
struct kobject *k_name, *k_tmp;

2012-06-12 06:07:08

by Boaz Harrosh

Subject: Re: [PATCH] exofs: fix sparse non-ANSI function warning

On 06/12/2012 02:46 AM, Randy Dunlap wrote:

> From: Randy Dunlap <[email protected]>
>
> Fix sparse non-ANSI function warning:
>
> fs/exofs/sys.c:112:28: warning: non-ANSI function declaration of function 'exofs_sysfs_dbg_print'
>


Thanks, will push for 3.6 merge window. Might take me
a few days to push to linux-next

Boaz

> Signed-off-by: Randy Dunlap <[email protected]>
> ---
> fs/exofs/sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-35-rc2.orig/fs/exofs/sys.c
> +++ lnx-35-rc2/fs/exofs/sys.c
> @@ -109,7 +109,7 @@ static struct kobj_type odev_ktype = {
> static struct kobj_type uuid_ktype = {
> };
>
> -void exofs_sysfs_dbg_print()
> +void exofs_sysfs_dbg_print(void)
> {
> #ifdef CONFIG_EXOFS_DEBUG
> struct kobject *k_name, *k_tmp;

2012-06-12 06:22:04

by Boaz Harrosh

Subject: Re: [PATCH] exofs: fix sparse non-ANSI function warning

On 06/12/2012 09:06 AM, Boaz Harrosh wrote:

> On 06/12/2012 02:46 AM, Randy Dunlap wrote:
>
>> From: Randy Dunlap <[email protected]>
>>
>> Fix sparse non-ANSI function warning:
>>
>> fs/exofs/sys.c:112:28: warning: non-ANSI function declaration of function 'exofs_sysfs_dbg_print'
>>
>
>
> Thanks, will push for 3.6 merge window. Might take me
> a few days to push to linux-next
>


Linus already pushed this for -rc3, cool less work for me ;-)

Thanks guys
Boaz

> Boaz
>