2021-05-27 09:05:10

by Baokun Li

Subject: [PATCH -next] tracing: Remove set but not used variable 'ret'

Fixes gcc '-Wunused-but-set-variable' warning:

kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
kernel/trace/trace_events_hist.c:5228:6: warning:
variable ‘ret’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <[email protected]>
---
kernel/trace/trace_events_hist.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index c1abd63f1d6c..af4da32f7eab 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -5225,13 +5225,12 @@ static void unregister_field_var_hists(struct hist_trigger_data *hist_data)
struct trace_event_file *file;
unsigned int i;
char *cmd;
- int ret;

for (i = 0; i < hist_data->n_field_var_hists; i++) {
file = hist_data->field_var_hists[i]->hist_data->event_file;
cmd = hist_data->field_var_hists[i]->cmd;
- ret = event_hist_trigger_func(&trigger_hist_cmd, file,
- "!hist", "hist", cmd);
+ event_hist_trigger_func(&trigger_hist_cmd, file,
+ "!hist", "hist", cmd);
}
}

--
2.25.4

2021-06-15 02:45:31

by Baokun Li

Subject: Re: [PATCH -next] tracing: Remove set but not used variable 'ret'

ping

在 2021/5/27 17:10, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
> kernel/trace/trace_events_hist.c:5228:6: warning:
> variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <[email protected]>
> ---
> kernel/trace/trace_events_hist.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index c1abd63f1d6c..af4da32f7eab 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -5225,13 +5225,12 @@ static void unregister_field_var_hists(struct hist_trigger_data *hist_data)
> struct trace_event_file *file;
> unsigned int i;
> char *cmd;
> - int ret;
>
> for (i = 0; i < hist_data->n_field_var_hists; i++) {
> file = hist_data->field_var_hists[i]->hist_data->event_file;
> cmd = hist_data->field_var_hists[i]->cmd;
> - ret = event_hist_trigger_func(&trigger_hist_cmd, file,
> - "!hist", "hist", cmd);
> + event_hist_trigger_func(&trigger_hist_cmd, file,
> + "!hist", "hist", cmd);
> }
> }
>

2021-06-15 15:41:06

by Steven Rostedt

Subject: Re: [PATCH -next] tracing: Remove set but not used variable 'ret'

On Tue, 15 Jun 2021 09:59:10 +0800
"libaokun (A)" <[email protected]> wrote:

> ping
>
> 在 2021/5/27 17:10, Baokun Li 写道:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
> > kernel/trace/trace_events_hist.c:5228:6: warning:
> > variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >
> > It never used since introduction.

Which was a bug.

> >
> > Signed-off-by: Baokun Li <[email protected]>
>

This was fixed differently:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c610dba6e2beb1a16ac309672181d0090fb8d30

-- Steve

2021-06-16 01:12:40

by Baokun Li

Subject: Re: [PATCH -next] tracing: Remove set but not used variable 'ret'

Thank you for your reminder.

Best Regards.


在 2021/6/15 23:39, Steven Rostedt 写道:
> On Tue, 15 Jun 2021 09:59:10 +0800
> "libaokun (A)" <[email protected]> wrote:
>
>> ping
>>
>> 在 2021/5/27 17:10, Baokun Li 写道:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
>>> kernel/trace/trace_events_hist.c:5228:6: warning:
>>> variable ‘ret’ set but not used [-Wunused-but-set-variable]
>>>
>>> It never used since introduction.
> Which was a bug.
>
>>> Signed-off-by: Baokun Li <[email protected]>
> This was fixed differently:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c610dba6e2beb1a16ac309672181d0090fb8d30
>
> -- Steve
> .