2020-04-13 05:43:47

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] net: mvneta: Fix a typo

s/mvmeta/mvneta/

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 5be61f73b6ab..51889770958d 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -5383,7 +5383,7 @@ static int __init mvneta_driver_init(void)
{
int ret;

- ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, "net/mvmeta:online",
+ ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, "net/mvneta:online",
mvneta_cpu_online,
mvneta_cpu_down_prepare);
if (ret < 0)
--
2.20.1


2020-04-13 05:52:00

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

From: Christophe JAILLET <[email protected]>
Date: Sun, 12 Apr 2020 23:20:34 +0200

> s/mvmeta/mvneta/
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Applied, but please reply to Jakub's feedback explaining how you
found this.

Thank you.

2020-04-13 05:52:16

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

From: David Miller <[email protected]>
Date: Sun, 12 Apr 2020 21:21:01 -0700 (PDT)

> From: Christophe JAILLET <[email protected]>
> Date: Sun, 12 Apr 2020 23:20:34 +0200
>
>> s/mvmeta/mvneta/
>>
>> Signed-off-by: Christophe JAILLET <[email protected]>
>
> Applied, but please reply to Jakub's feedback explaining how you
> found this.

I meant "Joe's feedback" of course, my bad.

2020-04-13 10:37:02

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

On Mon, 2020-04-13 at 08:56 +0200, Christophe JAILLET wrote:
> Le 12/04/2020 ? 23:35, Joe Perches a ?crit :
> > On Sun, 2020-04-12 at 23:20 +0200, Christophe JAILLET wrote:
> > > s/mvmeta/mvneta/
> > nice. how did you find this?
>
> Hi,
>
> This is based on a bash script I've made a while ago (see [1])
> I've slightly updated it, but the idea is still the same. I search
> strings in a file with some variation on the file name (2 inverted
> chars, 1 missing char or 1 modified char).
>
> The output is horrible, and a lot of filtering should be done.
> It is much like noise, with MANY false positives. But I manage to dig
> some interesting stuff out of it.
>
> If interested in the updated script, just ask, but except the concept
> itself, I'm not sure than anything else worth anything and is should be
> rewritten from scratch.
>
> The update includes some tweaks in order to search into Kconfig files
> instead.
>
> CJ
>
> [1]: https://marc.info/?l=kernel-janitors&m=156382201306781&w=4

Nice.

I was wondering if you used levenshtein distance or something else.

https://en.wikipedia.org/wiki/Levenshtein_distance


2020-04-13 18:17:42

by Christophe JAILLET

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

Le 13/04/2020 à 09:15, Joe Perches a écrit :
> On Mon, 2020-04-13 at 08:56 +0200, Christophe JAILLET wrote:
>> Le 12/04/2020 à 23:35, Joe Perches a écrit :
>>> On Sun, 2020-04-12 at 23:20 +0200, Christophe JAILLET wrote:
>>>> s/mvmeta/mvneta/
>>> nice. how did you find this?
>> Hi,
>>
>> This is based on a bash script I've made a while ago (see [1])
>> I've slightly updated it, but the idea is still the same. I search
>> strings in a file with some variation on the file name (2 inverted
>> chars, 1 missing char or 1 modified char).
>>
>> The output is horrible, and a lot of filtering should be done.
>> It is much like noise, with MANY false positives. But I manage to dig
>> some interesting stuff out of it.
>>
>> If interested in the updated script, just ask, but except the concept
>> itself, I'm not sure than anything else worth anything and is should be
>> rewritten from scratch.
>>
>> The update includes some tweaks in order to search into Kconfig files
>> instead.
>>
>> CJ
>>
>> [1]: https://marc.info/?l=kernel-janitors&m=156382201306781&w=4
> Nice.
>
> I was wondering if you used levenshtein distance or something else.
>
> https://en.wikipedia.org/wiki/Levenshtein_distance
>
>
Well, kind of hand-written version :)

If of any interest:
https://marc.info/?l=linux-driver-devel&m=141798041130581&w=4

I don't remember having played with it myself, but it looks interesting.

CJ