From: Colin Ian King <[email protected]>
There is a hunk of code that is indented one level too deep, fix this
by removing the extra tabs.
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/md/bcache/super.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 4dee119c3664..a697a3a923cd 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1615,21 +1615,21 @@ static void conditional_stop_bcache_device(struct cache_set *c,
*/
pr_warn("stop_when_cache_set_failed of %s is \"auto\" and cache is dirty, stop it to avoid potential data corruption.",
d->disk->disk_name);
- /*
- * There might be a small time gap that cache set is
- * released but bcache device is not. Inside this time
- * gap, regular I/O requests will directly go into
- * backing device as no cache set attached to. This
- * behavior may also introduce potential inconsistence
- * data in writeback mode while cache is dirty.
- * Therefore before calling bcache_device_stop() due
- * to a broken cache device, dc->io_disable should be
- * explicitly set to true.
- */
- dc->io_disable = true;
- /* make others know io_disable is true earlier */
- smp_mb();
- bcache_device_stop(d);
+ /*
+ * There might be a small time gap that cache set is
+ * released but bcache device is not. Inside this time
+ * gap, regular I/O requests will directly go into
+ * backing device as no cache set attached to. This
+ * behavior may also introduce potential inconsistence
+ * data in writeback mode while cache is dirty.
+ * Therefore before calling bcache_device_stop() due
+ * to a broken cache device, dc->io_disable should be
+ * explicitly set to true.
+ */
+ dc->io_disable = true;
+ /* make others know io_disable is true earlier */
+ smp_mb();
+ bcache_device_stop(d);
} else {
/*
* dc->stop_when_cache_set_failed == BCH_CACHED_STOP_AUTO
--
2.19.1
On 12/22/18 7:18 上午, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a hunk of code that is indented one level too deep, fix this
> by removing the extra tabs.
>
> Signed-off-by: Colin Ian King <[email protected]>
Hi Colin,
Nice catch, thank you! I will add it into my for-next directory.
Coly Li
> ---
> drivers/md/bcache/super.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 4dee119c3664..a697a3a923cd 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1615,21 +1615,21 @@ static void conditional_stop_bcache_device(struct cache_set *c,
> */
> pr_warn("stop_when_cache_set_failed of %s is \"auto\" and cache is dirty, stop it to avoid potential data corruption.",
> d->disk->disk_name);
> - /*
> - * There might be a small time gap that cache set is
> - * released but bcache device is not. Inside this time
> - * gap, regular I/O requests will directly go into
> - * backing device as no cache set attached to. This
> - * behavior may also introduce potential inconsistence
> - * data in writeback mode while cache is dirty.
> - * Therefore before calling bcache_device_stop() due
> - * to a broken cache device, dc->io_disable should be
> - * explicitly set to true.
> - */
> - dc->io_disable = true;
> - /* make others know io_disable is true earlier */
> - smp_mb();
> - bcache_device_stop(d);
> + /*
> + * There might be a small time gap that cache set is
> + * released but bcache device is not. Inside this time
> + * gap, regular I/O requests will directly go into
> + * backing device as no cache set attached to. This
> + * behavior may also introduce potential inconsistence
> + * data in writeback mode while cache is dirty.
> + * Therefore before calling bcache_device_stop() due
> + * to a broken cache device, dc->io_disable should be
> + * explicitly set to true.
> + */
> + dc->io_disable = true;
> + /* make others know io_disable is true earlier */
> + smp_mb();
> + bcache_device_stop(d);
> } else {
> /*
> * dc->stop_when_cache_set_failed == BCH_CACHED_STOP_AUTO
>