On 4/18/22 07:07, Holger Hoffstätte wrote:
> On 2022-04-18 14:10, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.15.35 release.
>> There are 189 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c: In function hubbub31_verify_allow_pstate_change_high':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c:994:17: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
> 994 | udelay(1);
> | ^~~~~~
>
> Caused by "drm-amd-display-add-pstate-verification-and-recovery-for-dcn31.patch".
> Explicitly includng <linux/delay.h> in dcn31_hubbub.c fixes it.
>
> Current mainline version of dcn31_hubbub.c does not explicitly include
> <linux/delay.h>, so there seems to be some general inconsistency wrt.
> which dcn module includes what.
>
> CC'ing Nicholas Kazlauskas.
>
Should add: The problem is only seen with 32-bit (i386) builds.
Guenter
On 4/18/22 10:27 AM, Guenter Roeck wrote:
> On 4/18/22 07:07, Holger Hoffstätte wrote:
>> On 2022-04-18 14:10, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.35 release.
>>> There are 189 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c: In function hubbub31_verify_allow_pstate_change_high':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c:994:17: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
>> 994 | udelay(1);
>> | ^~~~~~
>>
>> Caused by "drm-amd-display-add-pstate-verification-and-recovery-for-dcn31.patch".
>> Explicitly includng <linux/delay.h> in dcn31_hubbub.c fixes it.
>>
>> Current mainline version of dcn31_hubbub.c does not explicitly include
>> <linux/delay.h>, so there seems to be some general inconsistency wrt.
>> which dcn module includes what.
>>
>> CC'ing Nicholas Kazlauskas.
>>
> Should add: The problem is only seen with 32-bit (i386) builds.
>
I am seeing the same build failure on x86_64 build on AMD Ryzen 7 4700Gtest system
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c:994:17: error: implicit declaration of function ‘udelay’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
thanks,
-- Shuah
On 2022-04-18 18:27, Guenter Roeck wrote:
> On 4/18/22 07:07, Holger Hoffstätte wrote:
>> On 2022-04-18 14:10, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.35 release.
>>> There are 189 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c: In function hubbub31_verify_allow_pstate_change_high':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c:994:17: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
>> 994 | udelay(1);
>> | ^~~~~~
>>
>> Caused by "drm-amd-display-add-pstate-verification-and-recovery-for-dcn31.patch".
>> Explicitly includng <linux/delay.h> in dcn31_hubbub.c fixes it.
>>
>> Current mainline version of dcn31_hubbub.c does not explicitly include
>> <linux/delay.h>, so there seems to be some general inconsistency wrt.
>> which dcn module includes what.
>>
>> CC'ing Nicholas Kazlauskas.
>>
> Should add: The problem is only seen with 32-bit (i386) builds.
I found this while building on my Zen2 Thinkpad, which is definitely 64 bits. :)
-h