2022-04-18 04:04:26

by Ze Zhang

Subject: [PATCH 1/2] selftests/ftrace: add mips support for kprobe args string tests

This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
Add s390 support for kprobe args tests").

Signed-off-by: Ze Zhang <[email protected]>
---
.../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
index dc7ade196798..459741565222 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
@@ -25,6 +25,9 @@ ppc*)
s390*)
ARG1=%r2
;;
+mips*)
+ ARG1=%r4
+;;
*)
echo "Please implement other architecture here"
exit_untested
--
2.20.1

2022-04-19 16:54:02

by Masami Hiramatsu

Subject: Re: [PATCH 1/2] selftests/ftrace: add mips support for kprobe args string tests

On Mon, 18 Apr 2022 13:29:57 -0400
Steven Rostedt <[email protected]> wrote:

> On Sat, 16 Apr 2022 19:48:47 +0800
> Ze Zhang <[email protected]> wrote:
>
> > This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
> > Add s390 support for kprobe args tests").

Thanks for adding MIPS support!

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

> >
> > Signed-off-by: Ze Zhang <[email protected]>
> > ---
> > .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> > index dc7ade196798..459741565222 100644
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> > @@ -25,6 +25,9 @@ ppc*)
> > s390*)
> > ARG1=%r2
> > ;;
> > +mips*)
> > + ARG1=%r4
> > +;;
> > *)
> > echo "Please implement other architecture here"
> > exit_untested
>
>
> Needs an Ack from Masami, and then Shuah could take it.
>
> Acked-by: Steven Rostedt (Google) <[email protected]>
>
> -- Steve


--
Masami Hiramatsu <[email protected]>

2022-04-20 16:25:38

by Steven Rostedt

Subject: Re: [PATCH 1/2] selftests/ftrace: add mips support for kprobe args string tests

On Sat, 16 Apr 2022 19:48:47 +0800
Ze Zhang <[email protected]> wrote:

> This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
> Add s390 support for kprobe args tests").
>
> Signed-off-by: Ze Zhang <[email protected]>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index dc7ade196798..459741565222 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -25,6 +25,9 @@ ppc*)
> s390*)
> ARG1=%r2
> ;;
> +mips*)
> + ARG1=%r4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested


Needs an Ack from Masami, and then Shuah could take it.

Acked-by: Steven Rostedt (Google) <[email protected]>

-- Steve

2022-04-21 01:59:35

by Shuah Khan

Subject: Re: [PATCH 1/2] selftests/ftrace: add mips support for kprobe args string tests

On 4/18/22 7:12 PM, Masami Hiramatsu wrote:
> On Mon, 18 Apr 2022 13:29:57 -0400
> Steven Rostedt <[email protected]> wrote:
>
>> On Sat, 16 Apr 2022 19:48:47 +0800
>> Ze Zhang <[email protected]> wrote:
>>
>>> This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
>>> Add s390 support for kprobe args tests").
>
> Thanks for adding MIPS support!
>
> Acked-by: Masami Hiramatsu <[email protected]>
>
> Thank you!
>
>>>
>>> Signed-off-by: Ze Zhang <[email protected]>

Thank you all. I will pick this up for next

thanks,
-- Shuah