2022-11-07 10:59:24

by Konrad Dybcio

Subject: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask

From: Konrad Dybcio <[email protected]>

SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.

Suggested-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 27f029fdc682..06897a497eb7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -86,7 +86,6 @@
BIT(MDP_INTF1_INTR) | \
BIT(MDP_INTF2_INTR) | \
BIT(MDP_INTF3_INTR) | \
- BIT(MDP_INTF4_INTR) | \
BIT(MDP_AD4_0_INTR) | \
BIT(MDP_AD4_1_INTR))

--
2.38.1

2022-11-16 12:01:04

by Abhinav Kumar

Subject: Re: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask

On 11/7/2022 2:37 AM, Konrad Dybcio wrote:
> From: Konrad Dybcio <[email protected]>
>
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
> Suggested-by: Dmitry Baryshkov <[email protected]>
> Signed-off-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Konrad Dybcio <[email protected]>

It is true that SDM845 doesnt have INTF4. I was a bit concerned whether
this would impact SM8150 as that re-uses the IRQ_SDM845_MASK but even
SM8150 doesnt have INTF4.

A minor nit, the subject convention in this file seems to be drm/msm/dpu
and not drm/msm/dpu1.

Other than that,

Reviewed-by: Abhinav Kumar <[email protected]>


> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 27f029fdc682..06897a497eb7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -86,7 +86,6 @@
> BIT(MDP_INTF1_INTR) | \
> BIT(MDP_INTF2_INTR) | \
> BIT(MDP_INTF3_INTR) | \
> - BIT(MDP_INTF4_INTR) | \
> BIT(MDP_AD4_0_INTR) | \
> BIT(MDP_AD4_1_INTR))
>

2023-01-09 23:19:08

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask

On Mon, 07 Nov 2022 11:37:36 +0100, Konrad Dybcio wrote:
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
>

Applied, thanks!

[1/1] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
https://gitlab.freedesktop.org/lumag/msm/-/commit/a685d27f2201

Best regards,
--
Dmitry Baryshkov <[email protected]>