2012-11-19 11:21:12

by Tushar Behera

Subject: [PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

commit baf05aa9271b ("bug: introduce BUILD_BUG_ON_INVALID() macro")
introduces this macro when only _CHECKER_ is defined. Define
a silent macro in the else condition to fix following sparse
warning.

mm/filemap.c:395:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
mm/filemap.c:396:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
include/linux/mm.h:419:9: error: not a function <noident>

Signed-off-by: Tushar Behera <[email protected]>
---
include/linux/bug.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/bug.h b/include/linux/bug.h
index aaac4bb..b1cf40d 100644
--- a/include/linux/bug.h
+++ b/include/linux/bug.h
@@ -15,6 +15,7 @@ struct pt_regs;
#define BUILD_BUG_ON_NOT_POWER_OF_2(n)
#define BUILD_BUG_ON_ZERO(e) (0)
#define BUILD_BUG_ON_NULL(e) ((void*)0)
+#define BUILD_BUG_ON_INVALID(e) (0)
#define BUILD_BUG_ON(condition)
#define BUILD_BUG() (0)
#else /* __CHECKER__ */
--
1.7.4.1

2012-11-19 11:40:12

by Konstantin Khlebnikov

Subject: Re: [PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

Tushar Behera wrote:
> commit baf05aa9271b ("bug: introduce BUILD_BUG_ON_INVALID() macro")
> introduces this macro when only _CHECKER_ is defined. Define
> a silent macro in the else condition to fix following sparse
> warning.
>
> mm/filemap.c:395:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> mm/filemap.c:396:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> include/linux/mm.h:419:9: error: not a function<noident>
>
> Signed-off-by: Tushar Behera<[email protected]>

Thanks.

Signed-off-by: Konstantin Khlebnikov <[email protected]>

> ---
> include/linux/bug.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/bug.h b/include/linux/bug.h
> index aaac4bb..b1cf40d 100644
> --- a/include/linux/bug.h
> +++ b/include/linux/bug.h
> @@ -15,6 +15,7 @@ struct pt_regs;
> #define BUILD_BUG_ON_NOT_POWER_OF_2(n)
> #define BUILD_BUG_ON_ZERO(e) (0)
> #define BUILD_BUG_ON_NULL(e) ((void*)0)
> +#define BUILD_BUG_ON_INVALID(e) (0)
> #define BUILD_BUG_ON(condition)
> #define BUILD_BUG() (0)
> #else /* __CHECKER__ */