2023-12-01 08:35:22

by Michal Simek

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: hwmon: Increase max number of io-channels

The Analog Monitoring System (AMS) defines 51 channels
(Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml)
that's why increase number to 51.

Signed-off-by: Michal Simek <[email protected]>
Acked-by: Conor Dooley <[email protected]>
---

Changes in v2:
- Add Conor's ack
- Update commit message

Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
index e5b24782f448..be5c7d4579bb 100644
--- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
+++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
@@ -19,7 +19,7 @@ properties:

io-channels:
minItems: 1
- maxItems: 8 # Should be enough
+ maxItems: 51 # Should be enough
description: >
List of phandles to ADC channels to read the monitoring values

--
2.36.1


2023-12-03 17:16:20

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: hwmon: Increase max number of io-channels

On Fri, Dec 01, 2023 at 09:35:00AM +0100, Michal Simek wrote:
> The Analog Monitoring System (AMS) defines 51 channels
> (Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml)
> that's why increase number to 51.
>
> Signed-off-by: Michal Simek <[email protected]>
> Acked-by: Conor Dooley <[email protected]>

Applied to hwmon-next. If there are still concerns about the commit message
please let me know and I'll drop it until resolved.

Thanks,
Guenter

2023-12-04 00:35:09

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: hwmon: Increase max number of io-channels

On Sun, Dec 03, 2023 at 09:15:40AM -0800, Guenter Roeck wrote:
> On Fri, Dec 01, 2023 at 09:35:00AM +0100, Michal Simek wrote:
> > The Analog Monitoring System (AMS) defines 51 channels
> > (Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml)
> > that's why increase number to 51.
> >
> > Signed-off-by: Michal Simek <[email protected]>
> > Acked-by: Conor Dooley <[email protected]>
>
> Applied to hwmon-next. If there are still concerns about the commit message
> please let me know and I'll drop it until resolved.

You're good. I did ack the v1 wording even if I didn't like it, didn't
feel it was worth one resend, definitely not requesting _two_ resends.


Attachments:
(No filename) (701.00 B)
signature.asc (235.00 B)
Download all attachments