2013-03-01 13:11:32

by Sergei Shtylyov

Subject: Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig

Hello.

On 01-03-2013 5:32, Aaron Lu wrote:

> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.

> Signed-off-by: Aaron Lu <[email protected]>
> ---
> drivers/ata/Kconfig | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 3e751b7..d7d210e 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -59,15 +59,16 @@ config ATA_ACPI
> option libata.noacpi=1
>
> config SATA_ZPODD
> - bool "SATA Zero Power ODD Support"
> + bool "SATA Zero Power Optical Disc Drive(ZPODD) support"

Need a space before open paren.

> depends on ATA_ACPI
> default n
> help
> - This option adds support for SATA ZPODD. It requires both
> - ODD and the platform support, and if enabled, will automatically
> - power on/off the ODD when certain condition is satisfied. This
> - does not impact user's experience of the ODD, only power is saved
> - when ODD is not in use(i.e. no disc inside).
> + This option adds support for SATA Zero Power Optical Disc
> + Drive(ZPODD). It requires both the ODD and the platform

Same here.

> + support, and if enabled, will automatically power on/off the
> + ODD when certain condition is satisfied. This does not impact
> + end user's experience of the ODD, only power is saved when
> + the ODD is not in use(i.e. no disc inside).

And here.

MBR, Sergei

2013-03-02 04:59:35

by Aaron Lu

Subject: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

ODD is not a common TLA for non-ATA people so they will get confused
by its meaning when they are configuring the kernel. This patch fixed
this problem by using ODD only after stating what it is.

Signed-off-by: Aaron Lu <[email protected]>
---
v2:
Add a space before open paren as suggested by Sergei Shtylyov.

drivers/ata/Kconfig | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3e751b7..a5a3ebc 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
option libata.noacpi=1

config SATA_ZPODD
- bool "SATA Zero Power ODD Support"
+ bool "SATA Zero Power Optical Disc Drive (ZPODD) support"
depends on ATA_ACPI
default n
help
- This option adds support for SATA ZPODD. It requires both
- ODD and the platform support, and if enabled, will automatically
- power on/off the ODD when certain condition is satisfied. This
- does not impact user's experience of the ODD, only power is saved
- when ODD is not in use(i.e. no disc inside).
+ This option adds support for SATA Zero Power Optical Disc
+ Drive (ZPODD). It requires both the ODD and the platform
+ support, and if enabled, will automatically power on/off the
+ ODD when certain condition is satisfied. This does not impact
+ end user's experience of the ODD, only power is saved when
+ the ODD is not in use (i.e. no disc inside).

If unsure, say N.

--
1.8.1.2

2013-03-04 22:23:15

by Jeff Garzik

Subject: Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

On 03/02/2013 12:00 AM, Aaron Lu wrote:
> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.
>
> Signed-off-by: Aaron Lu <[email protected]>
> ---
> v2:
> Add a space before open paren as suggested by Sergei Shtylyov.
>
> drivers/ata/Kconfig | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)

applied