commit 49cb25e9290 x86: 'get rid of pt_regs argument in vm86/vm86old'
somehow breaks the colors when I play 'civilization I' under xdosemu.
During the intro of the game something the colors get messed up. When
the game begins the grass of the earth is red. Reverting the commit
fixes the problem.
--
Hans
Hi Hans,
Could you check if the attached patch solves your problem?
Greetings,
Alexander van Heukelum
On Sun, Mar 24, 2013, at 22:19, Hans de Bruin wrote:
> commit 49cb25e9290 x86: 'get rid of pt_regs argument in vm86/vm86old'
> somehow breaks the colors when I play 'civilization I' under xdosemu.
> During the intro of the game something the colors get messed up. When
> the game begins the grass of the earth is red. Reverting the commit
> fixes the problem.
>
> --
> Hans
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
On 03/26/2013 10:15 PM, Alexander van Heukelum wrote:
> Hi Hans,
>
> Could you check if the attached patch solves your problem?
>
Yep, the grass is green again.
--
Hans
Hi Al,
Hans de Bruin found a regression due to one of your changes. I asked him to test a fix and he reported back that it worked. (Thanks!) Can you see if you agree with the fix? Patch is attached due to webmail...
Greetings,
Alexander
On Wed, Mar 27, 2013 at 08:31:02PM +0100, Alexander van Heukelum wrote:
> Hi Al,
>
> Hans de Bruin found a regression due to one of your changes. I asked him to test a fix and he reported back that it worked. (Thanks!) Can you see if you agree with the fix? Patch is attached due to webmail...
Use SYSCALL_DEFINE{1,2} for vm86_old and vm86, please.
On Wed, Mar 27, 2013, at 20:46, Al Viro wrote:
> On Wed, Mar 27, 2013 at 08:31:02PM +0100, Alexander van Heukelum wrote:
> > Hi Al,
> >
> > Hans de Bruin found a regression due to one of your changes. I asked him to test a fix and he reported back that it worked. (Thanks!) Can you see if you agree with the fix? Patch is attached due to webmail...
>
> Use SYSCALL_DEFINE{1,2} for vm86_old and vm86, please.
Like this?
Greetings,
Alexander
On 03/27/2013 10:18 PM, Alexander van Heukelum wrote:
> On Wed, Mar 27, 2013, at 20:46, Al Viro wrote:
>> On Wed, Mar 27, 2013 at 08:31:02PM +0100, Alexander van Heukelum wrote:
>>> Hi Al,
>>>
>>> Hans de Bruin found a regression due to one of your changes. I asked him to test a fix and he reported back that it worked. (Thanks!) Can you see if you agree with the fix? Patch is attached due to webmail...
>>
>> Use SYSCALL_DEFINE{1,2} for vm86_old and vm86, please.
>
> Like this?
>
> Greetings,
> Alexander
>
Is there any progress?
--
Hans
On Fri, Apr 12, 2013, at 22:15, Hans de Bruin wrote:
> On 03/27/2013 10:18 PM, Alexander van Heukelum wrote:
> > On Wed, Mar 27, 2013, at 20:46, Al Viro wrote:
> >> On Wed, Mar 27, 2013 at 08:31:02PM +0100, Alexander van Heukelum wrote:
> >>> Hi Al,
> >>>
> >>> Hans de Bruin found a regression due to one of your changes. I asked him to test a fix and he reported back that it worked. (Thanks!) Can you see if you agree with the fix? Patch is attached due to webmail...
> >>
> >> Use SYSCALL_DEFINE{1,2} for vm86_old and vm86, please.
> >
> > Like this?
Hi Al,
Could you comment on the patch for the problem with the VM86 calls? I changed it to use SYSCALL_DEFINEx at the definition sites, and I changed the declarations in asm/syscalls.h to fit. If things are ok, can you take care of sending it to Linus?
Greetings,
Alexander
> > Greetings,
> > Alexander
> >
>
> Is there any progress?
>
> --
> Hans