2013-04-07 03:00:03

by Chen Gang

[permalink] [raw]
Subject: [PATCH] Drivers: Base: Regmap: fix warnings, use %lu instead of %d for printf format


fix warnings (with EXTRA_CFLAGS=-W):
format ?%d? expects argument of type ?int?,
but argument 4 has type ?size_t? [-Wformat]

Signed-off-by: Chen Gang <[email protected]>
---
drivers/base/regmap/regcache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index d81f605..275a2d2 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -590,7 +590,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data,

count = cur - base;

- dev_dbg(map->dev, "Writing %d bytes for %d registers from 0x%x-0x%x\n",
+ dev_dbg(map->dev, "Writing %lu bytes for %d registers from 0x%x-0x%x\n",
count * val_bytes, count, base, cur - 1);

map->cache_bypass = 1;
--
1.7.7.6


2013-04-07 09:08:48

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH] Drivers: Base: Regmap: fix warnings, use %lu instead of %d for printf format

Chen Gang <[email protected]> writes:

> fix warnings (with EXTRA_CFLAGS=-W):
> format ‘%d’ expects argument of type ‘int’,
> but argument 4 has type ‘size_t’ [-Wformat]
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> drivers/base/regmap/regcache.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
> index d81f605..275a2d2 100644
> --- a/drivers/base/regmap/regcache.c
> +++ b/drivers/base/regmap/regcache.c
> @@ -590,7 +590,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data,
>
> count = cur - base;
>
> - dev_dbg(map->dev, "Writing %d bytes for %d registers from 0x%x-0x%x\n",
> + dev_dbg(map->dev, "Writing %lu bytes for %d registers from 0x%x-0x%x\n",
> count * val_bytes, count, base, cur - 1);
>
> map->cache_bypass = 1;


Please read Documentation/printk-formats.txt. Thanks.


Bjørn

2013-04-07 09:24:06

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH] Drivers: Base: Regmap: fix warnings, use %lu instead of %d for printf format

On 2013年04月07日 17:08, Bjørn Mork wrote:
> Chen Gang <[email protected]> writes:
>
>> > fix warnings (with EXTRA_CFLAGS=-W):
>> > format ‘%d’ expects argument of type ‘int’,
>> > but argument 4 has type ‘size_t’ [-Wformat]
>> >
>> > Signed-off-by: Chen Gang <[email protected]>
>> > ---
>> > drivers/base/regmap/regcache.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
>> > index d81f605..275a2d2 100644
>> > --- a/drivers/base/regmap/regcache.c
>> > +++ b/drivers/base/regmap/regcache.c
>> > @@ -590,7 +590,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data,
>> >
>> > count = cur - base;
>> >
>> > - dev_dbg(map->dev, "Writing %d bytes for %d registers from 0x%x-0x%x\n",
>> > + dev_dbg(map->dev, "Writing %lu bytes for %d registers from 0x%x-0x%x\n",
>> > count * val_bytes, count, base, cur - 1);
>> >
>> > map->cache_bypass = 1;
>
> Please read Documentation/printk-formats.txt. Thanks.
>

thanks, I will send patch v2 (I should use "%zu" instead of "%lu")

:-)

>
> Bjørn
>
>


--
Chen Gang

Asianux Corporation

2013-04-07 09:33:09

by Chen Gang

[permalink] [raw]
Subject: [PATCH v2] Drivers: Base: Regmap: fix warnings, use %zu instead of %d for printf format


fix warnings (with EXTRA_CFLAGS=-W):
format ‘%d’ expects argument of type ‘int’,
but argument 4 has type ‘size_t’ [-Wformat]

Signed-off-by: Chen Gang <[email protected]>
---
drivers/base/regmap/regcache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index d81f605..a469748 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -590,7 +590,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data,

count = cur - base;

- dev_dbg(map->dev, "Writing %d bytes for %d registers from 0x%x-0x%x\n",
+ dev_dbg(map->dev, "Writing %zu bytes for %d registers from 0x%x-0x%x\n",
count * val_bytes, count, base, cur - 1);

map->cache_bypass = 1;
--
1.7.7.6

2013-04-07 11:33:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] Drivers: Base: Regmap: fix warnings, use %zu instead of %d for printf format

On Sun, Apr 07, 2013 at 05:32:39PM +0800, Chen Gang wrote:
>
> fix warnings (with EXTRA_CFLAGS=-W):
> format ‘%d’ expects argument of type ‘int’,
> but argument 4 has type ‘size_t’ [-Wformat]
>
> Signed-off-by: Chen Gang <[email protected]>

I've already applied a patch for this from someone else.

Attachments:
(No filename) (327.00 B)
 signature.asc (836.00 B)
Digital signature Download all attachments

2013-04-07 11:37:24

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH v2] Drivers: Base: Regmap: fix warnings, use %zu instead of %d for printf format

On 2013年04月07日 19:33, Mark Brown wrote:
> On Sun, Apr 07, 2013 at 05:32:39PM +0800, Chen Gang wrote:
>> >
>> > fix warnings (with EXTRA_CFLAGS=-W):
>> > format ‘%d’ expects argument of type ‘int’,
>> > but argument 4 has type ‘size_t’ [-Wformat]
>> >
>> > Signed-off-by: Chen Gang <[email protected]>
> I've already applied a patch for this from someone else.


ok, thanks.

it seems, I am too late !!

:-)


--
Chen Gang

Asianux Corporation