2022-07-06 13:35:23

by kernel test robot

[permalink] [raw]
Subject: [ammarfaizi2-block:broonie/sound/for-next 328/350] sound/soc/amd/acp-es8336.c:200:13: warning: variable 'ret' set but not used

tree: https://github.com/ammarfaizi2/linux-block broonie/sound/for-next
head: b182f4804a456b4ffdef1da14aef92c8d4cfda4a
commit: f94fa84058014f81ad526641f1b1f583ca2cf32f [328/350] ASoC: amd: enable machine driver build for Jadeite platform
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220706/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/ammarfaizi2/linux-block/commit/f94fa84058014f81ad526641f1b1f583ca2cf32f
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block broonie/sound/for-next
git checkout f94fa84058014f81ad526641f1b1f583ca2cf32f
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/amd/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

sound/soc/amd/acp-es8336.c: In function 'st_es8336_late_probe':
>> sound/soc/amd/acp-es8336.c:200:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
200 | int ret;
| ^~~


vim +/ret +200 sound/soc/amd/acp-es8336.c

02527c3f2300100 Vijendar Mukunda 2022-07-01 196
02527c3f2300100 Vijendar Mukunda 2022-07-01 197 static int st_es8336_late_probe(struct snd_soc_card *card)
02527c3f2300100 Vijendar Mukunda 2022-07-01 198 {
02527c3f2300100 Vijendar Mukunda 2022-07-01 199 struct acpi_device *adev;
02527c3f2300100 Vijendar Mukunda 2022-07-01 @200 int ret;
02527c3f2300100 Vijendar Mukunda 2022-07-01 201
02527c3f2300100 Vijendar Mukunda 2022-07-01 202 adev = acpi_dev_get_first_match_dev("ESSX8336", NULL, -1);
02527c3f2300100 Vijendar Mukunda 2022-07-01 203 if (adev)
02527c3f2300100 Vijendar Mukunda 2022-07-01 204 put_device(&adev->dev);
02527c3f2300100 Vijendar Mukunda 2022-07-01 205 codec_dev = acpi_get_first_physical_node(adev);
02527c3f2300100 Vijendar Mukunda 2022-07-01 206 if (!codec_dev)
02527c3f2300100 Vijendar Mukunda 2022-07-01 207 dev_err(card->dev, "can not find codec dev\n");
02527c3f2300100 Vijendar Mukunda 2022-07-01 208
02527c3f2300100 Vijendar Mukunda 2022-07-01 209 ret = devm_acpi_dev_add_driver_gpios(codec_dev, acpi_es8336_gpios);
02527c3f2300100 Vijendar Mukunda 2022-07-01 210
02527c3f2300100 Vijendar Mukunda 2022-07-01 211 gpio_pa = gpiod_get_optional(codec_dev, "pa-enable", GPIOD_OUT_LOW);
02527c3f2300100 Vijendar Mukunda 2022-07-01 212 if (IS_ERR(gpio_pa)) {
02527c3f2300100 Vijendar Mukunda 2022-07-01 213 ret = dev_err_probe(card->dev, PTR_ERR(gpio_pa),
02527c3f2300100 Vijendar Mukunda 2022-07-01 214 "could not get pa-enable GPIO\n");
02527c3f2300100 Vijendar Mukunda 2022-07-01 215 gpiod_put(gpio_pa);
02527c3f2300100 Vijendar Mukunda 2022-07-01 216 put_device(codec_dev);
02527c3f2300100 Vijendar Mukunda 2022-07-01 217 }
02527c3f2300100 Vijendar Mukunda 2022-07-01 218 return 0;
02527c3f2300100 Vijendar Mukunda 2022-07-01 219 }
02527c3f2300100 Vijendar Mukunda 2022-07-01 220

:::::: The code at line 200 was first introduced by commit
:::::: 02527c3f2300100a25524c8c020d98c7957e485e ASoC: amd: add Machine driver for Jadeite platform

:::::: TO: Vijendar Mukunda <[email protected]>
:::::: CC: Mark Brown <[email protected]>

--
0-DAY CI Kernel Test Service
https://01.org/lkp


2022-07-06 13:40:47

by Vijendar Mukunda

[permalink] [raw]
Subject: Re: [ammarfaizi2-block:broonie/sound/for-next 328/350] sound/soc/amd/acp-es8336.c:200:13: warning: variable 'ret' set but not used

On 7/6/22 6:46 PM, kernel test robot wrote:
> tree: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block&amp;data=05%7C01%7CVijendar.Mukunda%40amd.com%7C0e2df47acb3a4a45cef108da5f51d702%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927102343485757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=iomgwZKDI83uZCQDRvGYgcvKuKh%2Bo13lPp3nfbRrTyg%3D&amp;reserved=0 broonie/sound/for-next
> head: b182f4804a456b4ffdef1da14aef92c8d4cfda4a
> commit: f94fa84058014f81ad526641f1b1f583ca2cf32f [328/350] ASoC: amd: enable machine driver build for Jadeite platform
> config: i386-allyesconfig (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20220706%2F202207062130.ZOiHtbFz-lkp%40intel.com%2Fconfig&amp;data=05%7C01%7CVijendar.Mukunda%40amd.com%7C0e2df47acb3a4a45cef108da5f51d702%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927102343485757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=emcKRng%2FBGZmBQYhxmHftQXVrjfMVMUv8OR99DrZCHA%3D&amp;reserved=0)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
> # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block%2Fcommit%2Ff94fa84058014f81ad526641f1b1f583ca2cf32f&amp;data=05%7C01%7CVijendar.Mukunda%40amd.com%7C0e2df47acb3a4a45cef108da5f51d702%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927102343485757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=zhjq5SzIYw291Z%2Bpo2dlWPqYoPQqT3tkXBfHTMbaAUY%3D&amp;reserved=0
> git remote add ammarfaizi2-block https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block&amp;data=05%7C01%7CVijendar.Mukunda%40amd.com%7C0e2df47acb3a4a45cef108da5f51d702%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927102343485757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=iomgwZKDI83uZCQDRvGYgcvKuKh%2Bo13lPp3nfbRrTyg%3D&amp;reserved=0
> git fetch --no-tags ammarfaizi2-block broonie/sound/for-next
> git checkout f94fa84058014f81ad526641f1b1f583ca2cf32f
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/amd/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
> sound/soc/amd/acp-es8336.c: In function 'st_es8336_late_probe':
>>> sound/soc/amd/acp-es8336.c:200:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
will fix it and share the supplement patch.

-
Vijendar
> 200 | int ret;
> | ^~~
>
>
> vim +/ret +200 sound/soc/amd/acp-es8336.c
>
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 196
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 197 static int st_es8336_late_probe(struct snd_soc_card *card)
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 198 {
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 199 struct acpi_device *adev;
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 @200 int ret;
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 201
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 202 adev = acpi_dev_get_first_match_dev("ESSX8336", NULL, -1);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 203 if (adev)
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 204 put_device(&adev->dev);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 205 codec_dev = acpi_get_first_physical_node(adev);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 206 if (!codec_dev)
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 207 dev_err(card->dev, "can not find codec dev\n");
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 208
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 209 ret = devm_acpi_dev_add_driver_gpios(codec_dev, acpi_es8336_gpios);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 210
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 211 gpio_pa = gpiod_get_optional(codec_dev, "pa-enable", GPIOD_OUT_LOW);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 212 if (IS_ERR(gpio_pa)) {
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 213 ret = dev_err_probe(card->dev, PTR_ERR(gpio_pa),
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 214 "could not get pa-enable GPIO\n");
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 215 gpiod_put(gpio_pa);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 216 put_device(codec_dev);
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 217 }
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 218 return 0;
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 219 }
> 02527c3f2300100 Vijendar Mukunda 2022-07-01 220
>
> :::::: The code at line 200 was first introduced by commit
> :::::: 02527c3f2300100a25524c8c020d98c7957e485e ASoC: amd: add Machine driver for Jadeite platform
>
> :::::: TO: Vijendar Mukunda <[email protected]>
> :::::: CC: Mark Brown <[email protected]>
>