2013-04-24 11:36:55

by Geert Uytterhoeven

Subject: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach()

drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function

And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
to fix this.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
index a20d691..3a1f976 100644
--- a/drivers/media/usb/dvb-usb-v2/anysee.c
+++ b/drivers/media/usb/dvb-usb-v2/anysee.c
@@ -638,7 +638,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
{
struct anysee_state *state = adap_to_priv(adap);
struct dvb_usb_device *d = adap_to_d(adap);
- int ret;
+ int ret = 0;
u8 tmp;
struct i2c_msg msg[2] = {
{
--
1.7.0.4

2013-04-24 11:37:08

by Geert Uytterhoeven

Subject: [PATCH 2/2] [media] anysee: Grammar s/report the/report to/

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
index 3a1f976..1760fee 100644
--- a/drivers/media/usb/dvb-usb-v2/anysee.c
+++ b/drivers/media/usb/dvb-usb-v2/anysee.c
@@ -885,7 +885,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
/* we have no frontend :-( */
ret = -ENODEV;
dev_err(&d->udev->dev, "%s: Unsupported Anysee version. " \
- "Please report the " \
+ "Please report to " \
"<[email protected]>.\n",
KBUILD_MODNAME);
}
--
1.7.0.4

2013-04-25 15:58:18

by Antti Palosaari

Subject: Re: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach()

On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote:
> drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
> drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function
>
> And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Antti Palosaari <[email protected]>
Reviewed-by: Antti Palosaari <[email protected]>


> ---
> drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index a20d691..3a1f976 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -638,7 +638,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
> {
> struct anysee_state *state = adap_to_priv(adap);
> struct dvb_usb_device *d = adap_to_d(adap);
> - int ret;
> + int ret = 0;
> u8 tmp;
> struct i2c_msg msg[2] = {
> {
>


--
http://palosaari.fi/

2013-04-25 15:58:44

by Antti Palosaari

Subject: Re: [PATCH 2/2] [media] anysee: Grammar s/report the/report to/

On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <[email protected]>


Acked-by: Antti Palosaari <[email protected]>
Reviewed-by: Antti Palosaari <[email protected]>

> ---
> drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index 3a1f976..1760fee 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -885,7 +885,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
> /* we have no frontend :-( */
> ret = -ENODEV;
> dev_err(&d->udev->dev, "%s: Unsupported Anysee version. " \
> - "Please report the " \
> + "Please report to " \
> "<[email protected]>.\n",
> KBUILD_MODNAME);
> }
>


--
http://palosaari.fi/