2013-05-23 06:03:50

by Michal Simek

[permalink] [raw]
Subject: [PATCH] audit: Fix decimal constant description

Attachments:
(No filename) (1.11 kB)
 (No filename) (198.00 B)
 Download all attachments

2013-06-05 14:53:08

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] audit: Fix decimal constant description

Hi guys,

any comment on this?

Geert: I fixes one warning reported in your regression log.

Thanks,
Michal

On 05/23/2013 08:03 AM, Michal Simek wrote:
> Use proper decimal type for comparison with u32.
>
> Compilation warning was introduced by:
> "audit: Make testing for a valid loginuid explicit."
> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>
> Warning:
> kernel/auditfilter.c: In function 'audit_data_to_entry':
> kernel/auditfilter.c:426:3: warning: this decimal constant
> is unsigned only in ISO C90 [enabled by default]
> if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>
> Signed-off-by: Michal Simek <[email protected]>
> CC: Al Viro <[email protected]>
> CC: Eric Paris <[email protected]>
> ---
> kernel/auditfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 83a2970..cfa1f73 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
> f->lsm_rule = NULL;
>
> /* Support legacy tests for a valid loginuid */
> - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
> + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
> f->type = AUDIT_LOGINUID_SET;
> f->val = 0;
> }
> --
> 1.8.2.3
>


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-24 09:03:53

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] audit: Fix decimal constant description

On Wed, Jun 5, 2013 at 4:53 PM, Michal Simek <[email protected]> wrote:
> any comment on this?
>
> Geert: I fixes one warning reported in your regression log.

Acked-by: Geert Uytterhoeven <[email protected]>

> On 05/23/2013 08:03 AM, Michal Simek wrote:
>> Use proper decimal type for comparison with u32.
>>
>> Compilation warning was introduced by:
>> "audit: Make testing for a valid loginuid explicit."
>> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>>
>> Warning:
>> kernel/auditfilter.c: In function 'audit_data_to_entry':
>> kernel/auditfilter.c:426:3: warning: this decimal constant
>> is unsigned only in ISO C90 [enabled by default]
>> if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> CC: Al Viro <[email protected]>
>> CC: Eric Paris <[email protected]>
>> ---
>> kernel/auditfilter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 83a2970..cfa1f73 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
>> f->lsm_rule = NULL;
>>
>> /* Support legacy tests for a valid loginuid */
>> - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>> + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
>> f->type = AUDIT_LOGINUID_SET;
>> f->val = 0;
>> }
>> --
>> 1.8.2.3
>>
>
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: http://www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>



--
Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds