2013-06-26 09:38:06

by Alexey Brodkin

Subject: [PATCH] arch/arc: angel4.dts - add description for "arc_emac"

With this patch we introduce DT "arc_emac" description for ARCangel4.
Description is based on info/example in
"Documentation/devicetree/bindings/net/arc_emac.txt".

Signed-off-by: Alexey Brodkin <[email protected]>

Cc: Andy Shevchenko <[email protected]>
Cc: Francois Romieu <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: Mischa Jonker <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Paul Gortmaker <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Florian Fainelli <[email protected]>
---
arch/arc/boot/dts/angel4.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arc/boot/dts/angel4.dts b/arch/arc/boot/dts/angel4.dts
index bae4f93..4fb2d6f 100644
--- a/arch/arc/boot/dts/angel4.dts
+++ b/arch/arc/boot/dts/angel4.dts
@@ -51,5 +51,21 @@
current-speed = <115200>;
status = "okay";
};
+
+ ethernet@c0fc2000 {
+ compatible = "snps,arc-emac";
+ reg = <0xc0fc2000 0x3c>;
+ interrupts = <6>;
+ mac-address = [ 00 11 22 33 44 55 ];
+ clock-frequency = <80000000>;
+ max-speed = <100>;
+ phy = <&phy0>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+ phy0: ethernet-phy@0 {
+ reg = <1>;
+ };
+ };
};
};
--
1.7.10.4

2013-06-26 09:42:14

by Vineet Gupta

Subject: Re: [PATCH] arch/arc: angel4.dts - add description for "arc_emac"

On 06/26/2013 03:07 PM, Alexey Brodkin wrote:
> With this patch we introduce DT "arc_emac" description for ARCangel4.
> Description is based on info/example in
> "Documentation/devicetree/bindings/net/arc_emac.txt".
>
> Signed-off-by: Alexey Brodkin <[email protected]>
>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Francois Romieu <[email protected]>
> Cc: Joe Perches <[email protected]>
> Cc: Vineet Gupta <[email protected]>
> Cc: Mischa Jonker <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Paul Gortmaker <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Florian Fainelli <[email protected]>
> ---
> arch/arc/boot/dts/angel4.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arc/boot/dts/angel4.dts b/arch/arc/boot/dts/angel4.dts
> index bae4f93..4fb2d6f 100644
> --- a/arch/arc/boot/dts/angel4.dts
> +++ b/arch/arc/boot/dts/angel4.dts
> @@ -51,5 +51,21 @@
> current-speed = <115200>;
> status = "okay";
> };
> +
> + ethernet@c0fc2000 {
> + compatible = "snps,arc-emac";
> + reg = <0xc0fc2000 0x3c>;
> + interrupts = <6>;
> + mac-address = [ 00 11 22 33 44 55 ];
> + clock-frequency = <80000000>;
> + max-speed = <100>;
> + phy = <&phy0>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + phy0: ethernet-phy@0 {
> + reg = <1>;
> + };
> + };
> };
> };

This looks good - for completeness sake, can you also send a patch to remove
legacy hardcodings for irq/mem-map from arch/arc/plat-arcfpga/include/*

-Vineet