2013-07-10 18:07:21

by Ramkumar Ramachandra

Subject: [PATCH] scripts: remove unused function in sortextable.c

Cc: David Daney <[email protected]>
Cc: Michal Marek <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
Trivial. I wonder why make didn't tell us?

scripts/sortextable.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/scripts/sortextable.c b/scripts/sortextable.c
index f9ce116..7c2310c 100644
--- a/scripts/sortextable.c
+++ b/scripts/sortextable.c
@@ -64,14 +64,6 @@ fail_file(void)
longjmp(jmpenv, SJ_FAIL);
}

-static void __attribute__((noreturn))
-succeed_file(void)
-{
- cleanup();
- longjmp(jmpenv, SJ_SUCCEED);
-}
-
-
/*
* Get the whole file as a programming convenience in order to avoid
* malloc+lseek+read+free of many pieces. If successful, then mmap
--
1.8.3.2.736.g869de25

2013-07-15 16:58:30

by David Daney

Subject: Re: [PATCH] scripts: remove unused function in sortextable.c

On 07/10/2013 11:03 AM, Ramkumar Ramachandra wrote:
> Cc: David Daney <[email protected]>
> Cc: Michal Marek <[email protected]>
> Signed-off-by: Ramkumar Ramachandra <[email protected]>

I haven't tested it, but it looks plausible.

Acked-by: David Daney <[email protected]>


> ---
> Trivial. I wonder why make didn't tell us?
>
> scripts/sortextable.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/scripts/sortextable.c b/scripts/sortextable.c
> index f9ce116..7c2310c 100644
> --- a/scripts/sortextable.c
> +++ b/scripts/sortextable.c
> @@ -64,14 +64,6 @@ fail_file(void)
> longjmp(jmpenv, SJ_FAIL);
> }
>
> -static void __attribute__((noreturn))
> -succeed_file(void)
> -{
> - cleanup();
> - longjmp(jmpenv, SJ_SUCCEED);
> -}
> -
> -
> /*
> * Get the whole file as a programming convenience in order to avoid
> * malloc+lseek+read+free of many pieces. If successful, then mmap
>

2013-07-25 14:21:33

by Michal Marek

Subject: Re: [PATCH] scripts: remove unused function in sortextable.c

On Mon, Jul 15, 2013 at 09:55:56AM -0700, David Daney wrote:
> On 07/10/2013 11:03 AM, Ramkumar Ramachandra wrote:
> >Cc: David Daney <[email protected]>
> >Cc: Michal Marek <[email protected]>
> >Signed-off-by: Ramkumar Ramachandra <[email protected]>
>
> I haven't tested it, but it looks plausible.
>
> Acked-by: David Daney <[email protected]>

Applied to kbuild.git#kbuild, thanks.

Michal