2017-09-21 13:41:28

by Rakesh Pandit

Subject: [PATCH V2] lightnvm: include NVM Express driver if OCSSD is selected for build

Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
in config file before building kernel. Also append PCI to depends as
select doesn't automatically add dependencies.

Signed-off-by: Rakesh Pandit <[email protected]>
---

V2: appends 'depends' with PCI

drivers/lightnvm/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
index ead61a9..2a953ef 100644
--- a/drivers/lightnvm/Kconfig
+++ b/drivers/lightnvm/Kconfig
@@ -4,7 +4,8 @@

menuconfig NVM
bool "Open-Channel SSD target support"
- depends on BLOCK && HAS_DMA
+ depends on BLOCK && HAS_DMA && PCI
+ select BLK_DEV_NVME
help
Say Y here to get to enable Open-channel SSDs.

--
2.5.0

2017-09-21 13:41:53

by Matias Bjørling

Subject: Re: [PATCH V2] lightnvm: include NVM Express driver if OCSSD is selected for build

On 09/21/2017 03:41 PM, Rakesh Pandit wrote:
> Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> in config file before building kernel. Also append PCI to depends as
> select doesn't automatically add dependencies.
>
> Signed-off-by: Rakesh Pandit <[email protected]>
> ---
>
> V2: appends 'depends' with PCI
>
> drivers/lightnvm/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index ead61a9..2a953ef 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,8 @@
>
> menuconfig NVM
> bool "Open-Channel SSD target support"
> - depends on BLOCK && HAS_DMA
> + depends on BLOCK && HAS_DMA && PCI
> + select BLK_DEV_NVME
> help
> Say Y here to get to enable Open-channel SSDs.
>
>

Thanks Rakesh.