2022-07-28 08:27:05

by Conor Dooley

Subject: [PATCH] fpga: microchip-spi: add missing module author entry

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
programming driver.

Signed-off-by: Conor Dooley <[email protected]>
---
drivers/fpga/microchip-spi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
index bd284c7b8dc9..7436976ea904 100644
--- a/drivers/fpga/microchip-spi.c
+++ b/drivers/fpga/microchip-spi.c
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
module_spi_driver(mpf_driver);

MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
MODULE_LICENSE("GPL");
--
2.36.1

2022-07-28 13:26:22

by Tom Rix

Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry

On 7/28/22 12:50 AM, Conor Dooley wrote:
> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> programming driver.
>
> Signed-off-by: Conor Dooley <[email protected]>
Reviewed-by: Tom Rix <[email protected]>
> ---
> drivers/fpga/microchip-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> index bd284c7b8dc9..7436976ea904 100644
> --- a/drivers/fpga/microchip-spi.c
> +++ b/drivers/fpga/microchip-spi.c
> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> module_spi_driver(mpf_driver);
>
> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> +MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
> MODULE_LICENSE("GPL");

2022-07-28 19:15:36

by Ivan Bornyakov

Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry

On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> programming driver.
>
> Signed-off-by: Conor Dooley <[email protected]>
> ---
> drivers/fpga/microchip-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> index bd284c7b8dc9..7436976ea904 100644
> --- a/drivers/fpga/microchip-spi.c
> +++ b/drivers/fpga/microchip-spi.c
> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> module_spi_driver(mpf_driver);
>
> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> +MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
> MODULE_LICENSE("GPL");
> --
> 2.36.1
>

Acked-by: Ivan Bornyakov <[email protected]>

Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
submitted a couple of other drivers without it, should I fix them?

2022-07-28 19:43:01

by Conor Dooley

Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry

On 28/07/2022 19:46, Ivan Bornyakov wrote:
> On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
>> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
>> programming driver.
>>
>> Signed-off-by: Conor Dooley <[email protected]>
>> ---
>> drivers/fpga/microchip-spi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
>> index bd284c7b8dc9..7436976ea904 100644
>> --- a/drivers/fpga/microchip-spi.c
>> +++ b/drivers/fpga/microchip-spi.c
>> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
>> module_spi_driver(mpf_driver);
>>
>> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
>> +MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
>> MODULE_LICENSE("GPL");
>> --
>> 2.36.1
>>
>
> Acked-by: Ivan Bornyakov <[email protected]>
>
> Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
> submitted a couple of other drivers without it, should I fix them?
>

It'll show up in modinfo. I don't think it's a big deal though.
/shrug
Conor.

2022-08-15 03:40:18

by Xu Yilun

Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry

On 2022-07-28 at 05:29:48 -0700, Tom Rix wrote:
>
> On 7/28/22 12:50 AM, Conor Dooley wrote:
> > Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> > programming driver.
> >
> > Signed-off-by: Conor Dooley <[email protected]>
> Reviewed-by: Tom Rix <[email protected]>

Acked-by: Xu Yilun <[email protected]>

Applied to for-next

> > ---
> > drivers/fpga/microchip-spi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> > index bd284c7b8dc9..7436976ea904 100644
> > --- a/drivers/fpga/microchip-spi.c
> > +++ b/drivers/fpga/microchip-spi.c
> > @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> > module_spi_driver(mpf_driver);
> > MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> > +MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
> > MODULE_LICENSE("GPL");
>