2019-11-12 15:48:53

by James Tai [戴志峰]

Subject: [PATCH v3 0/2] arm64: dts: Initial RTD1619 SoC and Realtek Mjolnir EVB support

Hi,

This series adds initial Device Trees for Realtek RTD1619 SoC and
Realtek Mjolnir EVB.

v2 -> v3:
* Adjust the address-cells and address-size property of root node
* Adjust ranges property of r-bus node
* Adjust uart node addressing
* Add comments for uart node
* Revert soc node

v1 -> v2:
* Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir
* Add uart1 and uart2 device node into rtd16xx.dtsi
* move cpus node and the interrupt-affinity into rtd16xx.dtsi
* Specify the r-bus ranges


Cc: [email protected]
Cc: Rob Herring <[email protected]>
Cc: Andreas F?rber <[email protected]>

James Tai (2):
dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
arm64: dts: realtek: Add RTD1619 SoC and Realtek Mjolnir EVB

.../devicetree/bindings/arm/realtek.yaml | 6 +
arch/arm64/boot/dts/realtek/Makefile | 2 +
.../boot/dts/realtek/rtd1619-mjolnir.dts | 40 +++++
arch/arm64/boot/dts/realtek/rtd1619.dtsi | 12 ++
arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 163 ++++++++++++++++++
5 files changed, 223 insertions(+)
create mode 100644 arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1619.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd16xx.dtsi

--
2.24.0

2019-11-15 03:08:07

by Andreas Färber

Subject: Re: [PATCH v3 0/2] arm64: dts: Initial RTD1619 SoC and Realtek Mjolnir EVB support

Hi James,

Am 12.11.19 um 16:45 schrieb James Tai:
> This series adds initial Device Trees for Realtek RTD1619 SoC and
> Realtek Mjolnir EVB.
>
> v2 -> v3:
> * Adjust the address-cells and address-size property of root node
> * Adjust ranges property of r-bus node
> * Adjust uart node addressing
> * Add comments for uart node
> * Revert soc node
>
> v1 -> v2:
> * Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir
> * Add uart1 and uart2 device node into rtd16xx.dtsi
> * move cpus node and the interrupt-affinity into rtd16xx.dtsi
> * Specify the r-bus ranges

Some observations of what is not in this patchset:

* There is neither /memreserve/ nor /reserved-memory here. What about
Boot ROM, TEE and RPC?
* The reset controllers for the UARTs are missing. Can we take the same
shortcut as in my RTD1395 patch to add them now, i.e. are they
compatible with RTD1295?
* Is the watchdog incompatible, or is it just not enabled by the
bootloader and depends on future, e.g., clk patches?
* Is the RTC not enabled on boot, similar to the other SoCs?

Regards,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)