2014-12-22 15:52:04

by Boris Ostrovsky

Subject: Testing preemptibility test in xen_setup_cpu_clockevents()

With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()) HVM guests no longer boot since we are
hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().

I don't think we need this test (PV or HVM), do we?


-boris

2014-12-22 16:10:13

by David Vrabel

Subject: Re: [Xen-devel] Testing preemptibility test in xen_setup_cpu_clockevents()

On 22/12/14 15:53, Boris Ostrovsky wrote:
> With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in
> native_smp_prepare_cpus()) HVM guests no longer boot since we are
> hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().
>
> I don't think we need this test (PV or HVM), do we?

It looks safe to remove the BUG_ON().

David