2014-12-22 18:31:16

by Boris Ostrovsky

Subject: [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer()

There is no reason for having it and, with commit 250a1ac685f1 ("x86,
smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()"), it prevents HVM guests from booting.

Signed-off-by: Boris Ostrovsky <[email protected]>
---
arch/x86/xen/time.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)

void xen_setup_cpu_clockevents(void)
{
- BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(&xen_clock_events.evt));
}

--
1.9.3

2014-12-23 10:35:03

by David Vrabel

Subject: Re: [Xen-devel] [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer()

On 22/12/14 18:33, Boris Ostrovsky wrote:
> There is no reason for having it and, with commit 250a1ac685f1 ("x86,
> smpboot: Remove pointless preempt_disable() in
> native_smp_prepare_cpus()"), it prevents HVM guests from booting.

Applied to stable/for-linus-3.19, thanks.

For arch-specific fixes I prefer the arch in the subject. e.g., "x86/xen:".

David