2014-12-29 09:28:12

by Jitendra

Subject: [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c

This is a patch to the s626.c file that fixes up a maximum 80 character limit
warning found by the checkpatch.pl tool

Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
---
drivers/staging/comedi/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index fc497dd..77f715b 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
for (i = 0; i < 2; i++) {
writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
- ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+ ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+ 0);
if (ret)
return ret;
}
--
1.9.1

2014-12-30 22:23:29

by Ian Abbott

Subject: Re: [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c

On 29/12/14 09:27, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up a maximum 80 character limit
> warning found by the checkpatch.pl tool
>
> Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
> ---
> drivers/staging/comedi/drivers/s626.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index fc497dd..77f715b 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
> for (i = 0; i < 2; i++) {
> writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
> s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> - ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> + ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> + 0);

Technically it meets the requirements, but our comedi house style is to
indent the continuation of the statement just past the opening
bracket/parenthesis like so:

ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
0);

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-