2015-02-05 12:47:21

by David Vrabel

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v5 0/2] x86/xen: add xen hypercall preemption

On 27/01/15 01:51, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <[email protected]>
>
> This v5 nukes tracing as David said it was useless, it also
> only adds support for 64-bit as its the only thing I can test,
> and slightly modifies the documentation in code as to why we
> want this. The no krobe thing is left in place as I haven't
> heard confirmation its kosher to remove it.

FYI, I went back an reviewed my last v4 patch and folded the
xen_end_upcall() change into it instead.

http://lists.xen.org/archives/html/xen-devel/2015-02/msg00682.html

This will be easier for arm/arm64 to make use of in the future since
there are fewer arch-specific changes.

David


2015-02-05 18:15:55

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v5 0/2] x86/xen: add xen hypercall preemption

On Thu, Feb 05, 2015 at 12:47:15PM +0000, David Vrabel wrote:
> On 27/01/15 01:51, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <[email protected]>
> >
> > This v5 nukes tracing as David said it was useless, it also
> > only adds support for 64-bit as its the only thing I can test,
> > and slightly modifies the documentation in code as to why we
> > want this. The no krobe thing is left in place as I haven't
> > heard confirmation its kosher to remove it.
>
> FYI, I went back an reviewed my last v4 patch and folded the
> xen_end_upcall() change into it instead.
>
> http://lists.xen.org/archives/html/xen-devel/2015-02/msg00682.html
>
> This will be easier for arm/arm64 to make use of in the future since
> there are fewer arch-specific changes.

I had taken similar approach first and determined using pt_regs was
safer after advice from Andy. I'll provide feedback on your new patchset.

Luis