2015-02-13 16:32:47

by Yi Li

Subject: [PATCH] xen: fix mcelog/stub depend issue in Kconfig

From: Yi Li <[email protected]>

Fix support mcelog/stub in Kconfig for Xen X86 platform

Signed-off-by: Yi Li <[email protected]>
---
drivers/xen/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index b812462..83ae68a 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -188,7 +188,7 @@ config XEN_PRIVCMD

config XEN_STUB
bool "Xen stub drivers"
- depends on XEN && X86_64 && BROKEN
+ depends on XEN && X86 && BROKEN
default n
help
Allow kernel to install stub drivers, to reserve space for Xen drivers,
@@ -240,7 +240,7 @@ config XEN_ACPI_PROCESSOR

config XEN_MCE_LOG
bool "Xen platform mcelog"
- depends on XEN_DOM0 && X86_64 && X86_MCE
+ depends on XEN_DOM0 && X86 && X86_MCE
default n
help
Allow kernel fetching MCE error from Xen platform and
--
1.7.12.4

2015-02-13 16:51:10

by David Vrabel

Subject: Re: [Xen-devel] [PATCH] xen: fix mcelog/stub depend issue in Kconfig

On 13/02/15 16:32, Yi Li wrote:
>
> From: Yi Li <[email protected]>
>
> Fix support mcelog/stub in Kconfig for Xen X86 platform

Is this actually sufficient? I'm fairly sure the Xen MCE driver does
not correctly handle the 64-bit ABI that Xen provides and there would
need to be some compat translations done.

> Signed-off-by: Yi Li <[email protected]>
> ---
> drivers/xen/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index b812462..83ae68a 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -188,7 +188,7 @@ config XEN_PRIVCMD
>
> config XEN_STUB
> bool "Xen stub drivers"
> - depends on XEN && X86_64 && BROKEN
> + depends on XEN && X86 && BROKEN
> default n
> help
> Allow kernel to install stub drivers, to reserve space for Xen drivers,
> @@ -240,7 +240,7 @@ config XEN_ACPI_PROCESSOR
>
> config XEN_MCE_LOG
> bool "Xen platform mcelog"
> - depends on XEN_DOM0 && X86_64 && X86_MCE
> + depends on XEN_DOM0 && X86 && X86_MCE
> default n
> help
> Allow kernel fetching MCE error from Xen platform and
>