2020-01-21 15:20:41

by Andy Shevchenko

Subject: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS

The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
introduced some new test cases to the test_bitmap.c module. Among these
it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.

Reported-by: Alex Shi <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
---
lib/test_bitmap.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 61ed71c1daba..6b13150667f5 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -278,6 +278,8 @@ static void __init test_replace(void)
unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
DECLARE_BITMAP(bmap, 1024);

+ BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
+
bitmap_zero(bmap, 1024);
bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
expect_eq_bitmap(bmap, exp3_0_1, nbits);
--
2.24.1

2020-01-22 02:07:48

by Alex Shi

Subject: Re: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS

?? 2020/1/21 ????11:18, Andy Shevchenko д??:
> The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
> introduced some new test cases to the test_bitmap.c module. Among these
> it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
>
> Reported-by: Alex Shi <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> lib/test_bitmap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 61ed71c1daba..6b13150667f5 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -278,6 +278,8 @@ static void __init test_replace(void)
> unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
> DECLARE_BITMAP(bmap, 1024);
>
> + BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
> +
> bitmap_zero(bmap, 1024);
> bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
> expect_eq_bitmap(bmap, exp3_0_1, nbits);
>

It looks nice. :)

Reviewed-by: Alex Shi <[email protected]>