2015-04-01 10:18:43

by David Vrabel

Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

On 26/03/15 12:16, Bob Liu wrote:
> There are several place using gnttab async unmap and wait for
> completion, so move the common code to a function
> gnttab_unmap_refs_async_wait_completion().
>
[...]
> +
> +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item)

This name is a bit wordy. Can you rename it to:
gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or
gnttab_unmap_refs_safe().

(I can't decide which is the best name.).

David

2015-04-01 11:56:13

by Bob Liu

Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

On 04/01/2015 06:18 PM, David Vrabel wrote:
> On 26/03/15 12:16, Bob Liu wrote:
>> There are several place using gnttab async unmap and wait for
>> completion, so move the common code to a function
>> gnttab_unmap_refs_async_wait_completion().
>>
> [...]
>> +
>> +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item)
>
> This name is a bit wordy. Can you rename it to:
> gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or

Sure, I think gnttab_unmap_refs_sync() is fine.
Will be updated.

> gnttab_unmap_refs_safe().
>
> (I can't decide which is the best name.).
>
> David
>

--
Regards,
-Bob